devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: Shawn Guo <shawnguo@kernel.org>, Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: misc: bk4: Add device tree binding for Liebherr's BK4 SPI bus
Date: Tue, 9 Oct 2018 12:21:14 +0200	[thread overview]
Message-ID: <20181009122114.39ff3553@jawa> (raw)
In-Reply-To: <20181008144350.GS3587@dragon>

[-- Attachment #1: Type: text/plain, Size: 2173 bytes --]

Hi Shawn,

> On Fri, Sep 28, 2018 at 12:26:55AM +0200, Lukasz Majewski wrote:
> > Add Device Tree binding document for Liebherr's BK4 external SPI
> > bus.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>  
> 
> There should really be a patch series consisting of this one and
> spidev change [1].
> 
> Since spidev has already been picked up, having a series including
> this and dts change would be the second option.  With DT folks' ACK,
> I can send bindings change together with DTS using it.

Any option will work for me :-).

> 
> Shawn
> 
> [1] https://lkml.org/lkml/2018/9/28/48
> 
> > ---
> >  Documentation/devicetree/bindings/misc/lwn-bk4.txt | 26
> > ++++++++++++++++++++++ 1 file changed, 26 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/misc/lwn-bk4.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/misc/lwn-bk4.txt
> > b/Documentation/devicetree/bindings/misc/lwn-bk4.txt new file mode
> > 100644 index 000000000000..d6a8c188c087
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/lwn-bk4.txt
> > @@ -0,0 +1,26 @@
> > +* Liebherr's BK4 controller external SPI
> > +
> > +A device which handles data acquisition from compatible industrial
> > +peripherals.
> > +The SPI is used for data and management purposes in both master and
> > +slave modes.
> > +
> > +Required properties:
> > +
> > +- compatible : Should be "lwn,bk4"
> > +
> > +Required SPI properties:
> > +
> > +- reg : Should be address of the device chip select within
> > +  the controller.
> > +
> > +- spi-max-frequency : Maximum SPI clocking speed of device in Hz,
> > should be
> > +  30MHz at most for the Liebherr's BK4 external bus.
> > +
> > +Example:
> > +
> > +spidev0: spi@0 {
> > +	compatible = "lwn,bk4";
> > +	spi-max-frequency = <30000000>;
> > +	reg = <0>;
> > +};
> > -- 
> > 2.11.0
> >   


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-10-09 10:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27 22:26 [PATCH] dt-bindings: misc: bk4: Add device tree binding for Liebherr's BK4 SPI bus Lukasz Majewski
2018-10-08 12:30 ` Lukasz Majewski
2018-10-08 14:43 ` Shawn Guo
2018-10-09 10:21   ` Lukasz Majewski [this message]
2018-10-15 10:17     ` Lukasz Majewski
2018-10-15 10:24       ` Mark Brown
2018-10-15 18:46 ` Rob Herring
2018-10-15 21:23   ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181009122114.39ff3553@jawa \
    --to=lukma@denx.de \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).