From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: devicetree@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/panel: Add DT bindings for Samsung S6D16D0
Date: Tue, 9 Oct 2018 21:26:33 +0200 [thread overview]
Message-ID: <20181009192633.GA13448@ravnborg.org> (raw)
In-Reply-To: <20181008110006.24561-1-linus.walleij@linaro.org>
On Mon, Oct 08, 2018 at 01:00:05PM +0200, Linus Walleij wrote:
> This adds the device tree bindings for the Samsung S6D16D0
> panel. This is a command mode only panel using DSI.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> .../display/panel/samsung,s6d16d0.txt | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6d16d0.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6d16d0.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6d16d0.txt
> new file mode 100644
> index 000000000000..b94e366f451b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6d16d0.txt
> @@ -0,0 +1,30 @@
> +Samsung S6D16D0 4" 864x480 AMOLED panel
> +
> +Required properties:
> + - compatible: should be:
> + "samsung,s6d16d0",
> + - reg: the virtual channel number of a DSI peripheral
> + - vdd1-supply: I/O voltage supply
> + - reset-gpios: a GPIO spec for the reset pin (active low)
That it is active low is part of the GPIO part and should not
be mandated as part of the binding?
> +
> +The device node can contain one 'port' child node with one child
> +'endpoint' node, according to the bindings defined in
> +media/video-interfaces.txt. This node should describe panel's video bus.
> +
> +Example:
> +&dsi {
> + ...
> +
> + panel@0 {
> + compatible = "samsung,s6d16d0";
> + reg = <0>;
> + vdd1-supply = <&foo>;
> + reset-gpios = <&foo_gpio 0 GPIO_ACTIVE_LOW>;
This line specifies if ACTIVE HIGH or LOW.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-10-09 19:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 11:00 [PATCH 1/2] drm/panel: Add DT bindings for Samsung S6D16D0 Linus Walleij
2018-10-09 19:26 ` Sam Ravnborg [this message]
2018-10-11 8:48 ` Linus Walleij
2018-10-11 8:59 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009192633.GA13448@ravnborg.org \
--to=sam@ravnborg.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).