From: David Gibson <david@gibson.dropbear.id.au>
To: Frank Rowand <frowand.list@gmail.com>
Cc: "AKASHI, Takahiro" <takahiro.akashi@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
David Howells <dhowells@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
David Miller <davem@davemloft.net>,
dyoung@redhat.com, Baoquan He <bhe@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
prudo@linux.ibm.com, Ard Biesheuvel <ard.biesheuvel@linaro.org>,
James Morse <james.morse@arm.com>,
bhsharma@redhat.com, kexec@lists.infradead.org,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel>
Subject: Re: [PATCH v15 06/16] of/fdt: add helper functions for handling properties
Date: Wed, 10 Oct 2018 11:30:16 +1100 [thread overview]
Message-ID: <20181010003016.GH7004@umbus.fritz.box> (raw)
In-Reply-To: <bd3d0472-1bd7-52ed-b9f6-b5edae8c8b6d@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 952 bytes --]
On Tue, Oct 09, 2018 at 11:02:29AM -0700, Frank Rowand wrote:
> On 10/04/18 22:06, AKASHI, Takahiro wrote:
[snip]
> >>>> +int fdt_setprop_reg(void *fdt, int nodeoffset, const char *name,
> >>>> + u64 addr, u64 size)
> >>>> +{
> >>>> + int addr_cells, size_cells;
> >>
> >> unsigned
> >
> > fdt_[address|size]_cell() returns an int.
>
> I stand corrected. They take advantage of the fact that valid values
> are in the range 0..4 and return a negative value for error.
I'm not sure if the spec formally defines that these values will fit
in a positive 'int'. But if addresses are 8GiB each, you're going to
have much bigger problems putting it in a device tree than this
function.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-10-10 0:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180928064841.14117-1-takahiro.akashi@linaro.org>
2018-09-28 6:48 ` [PATCH v15 06/16] of/fdt: add helper functions for handling properties AKASHI Takahiro
2018-09-28 9:04 ` kbuild test robot
2018-09-28 13:44 ` Rob Herring
2018-09-28 21:13 ` Frank Rowand
2018-10-05 5:06 ` AKASHI, Takahiro
2018-10-05 5:09 ` David Gibson
2018-10-09 18:02 ` Frank Rowand
2018-10-10 0:30 ` David Gibson [this message]
2018-10-10 1:04 ` AKASHI, Takahiro
2018-10-02 4:47 ` David Gibson
2018-10-02 9:04 ` AKASHI, Takahiro
2018-10-05 3:08 ` AKASHI, Takahiro
2018-10-05 13:23 ` Rob Herring
2018-10-09 0:37 ` AKASHI, Takahiro
2018-10-09 17:47 ` Frank Rowand
2018-10-10 1:14 ` AKASHI, Takahiro
2018-10-10 2:44 ` Frank Rowand
2018-09-28 6:48 ` [PATCH v15 12/16] arm64: kexec_file: add crash dump support AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010003016.GH7004@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=bhsharma@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dyoung@redhat.com \
--cc=frowand.list@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=james.morse@arm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=prudo@linux.ibm.com \
--cc=robh+dt@kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=takahiro.akashi@linaro.org \
--cc=vgoyal@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).