From: Rob Herring <robh@kernel.org>
To: Kun Yi <kunyi@google.com>
Cc: linux@roeck-us.net, linux-hwmon@vger.kernel.org,
jdelvare@suse.com, mark.rutland@arm.com,
devicetree@vger.kernel.org, rlippert@google.com,
benjaminfair@google.com, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v2] hwmon: (adm1275): Add device tree param for shunt resistor
Date: Fri, 12 Oct 2018 15:11:28 -0500 [thread overview]
Message-ID: <20181012201128.GA13628@bogus> (raw)
In-Reply-To: <20180928195800.153914-1-kunyi@google.com>
On Fri, Sep 28, 2018 at 12:58:00PM -0700, Kun Yi wrote:
> The ADM series of hotswap controllers support extending
> the current measurement range by using a sensing resistor
> value other than the typical 1 mOhm. For example, using a 0.5 mOhm
> sensing resistor doubles the maximal current can be measured.
>
> Current driver assumes a shunt resistor value of 1 mOhm in calculation,
> meaning for other resistor values, hwmon will report scaled
> current/power measurements. This patch adds a device tree parameter so
> that individual boards can configure its shunt resistor value.
>
> Signed-off-by: Kun Yi <kunyi@google.com>
> ---
> .../devicetree/bindings/hwmon/adm1275.txt | 25 +++++++++++++++++++
This should be a separate patch. In particular, the subject doesn't
really reflect that you are adding a new binding.
Otherwise, the binding looks fine.
> Documentation/hwmon/adm1275 | 3 +++
> drivers/hwmon/pmbus/adm1275.c | 15 +++++++++--
> 3 files changed, 41 insertions(+), 2 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/hwmon/adm1275.txt
prev parent reply other threads:[~2018-10-12 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 19:58 [PATCH v2] hwmon: (adm1275): Add device tree param for shunt resistor Kun Yi
2018-10-12 20:11 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012201128.GA13628@bogus \
--to=robh@kernel.org \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=kunyi@google.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=rlippert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).