From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v4 1/2] arm64: dts: allwinner: new board - Emlid Neutis N5 Date: Fri, 12 Oct 2018 22:23:30 +0200 Message-ID: <20181012202330.tdwedsof2bsnxkxn@flea> References: <1539012044-29998-2-git-send-email-aleksandr.aleksandrov@emlid.com> <1539339841-22235-1-git-send-email-aleksandr.aleksandrov@emlid.com> <1539339841-22235-2-git-send-email-aleksandr.aleksandrov@emlid.com> <20181012133914.GA32670@imagebutcher> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Return-path: Content-Disposition: inline In-Reply-To: <20181012133914.GA32670@imagebutcher> Sender: linux-kernel-owner@vger.kernel.org To: Aleksandr Aleksandrov Cc: Andreas =?utf-8?Q?F=C3=A4rber?= , Rob Herring , Mark Rutland , Chen-Yu Tsai , David Lechner , Thierry Reding , Florian Fainelli , Johan Hovold , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Fri, Oct 12, 2018 at 04:39:14PM +0300, Aleksandr Aleksandrov wrote: > Hi Andreas, > > Thanks for your feedback! > > > > + * > > > + * Copyright (C) 2018 Aleksandr Aleksandrov > > > + */ > > > + > > > +/dts-v1/; > > > + > > > +#include "sun50i-h5-emlid-neutis-n5.dtsi" > > > + > > > +/ { > > > + model = "Emlid Neutis N5 Developer board"; > > > + compatible = "emlid,neutis-n5-devboard", > > > + "emlid,neutis-n5", > > > > You are lacking bindings definitions for these new identifiers. The > > vendor prefix should be patch 1/3, the SoM/board compatibles 2/3 and > > this .dts[i] patch 3/3, so that only vendor prefixes and compatibles > > that are defined and don't result in checkpatch.pl warnings get used. > > Patch 2/3: > > commit 46dcb8632b36644cb20e6b35ede12ff0088a60eb > Author: Aleksandr Aleksandrov > Date: Fri Oct 12 16:22:28 2018 +0300 > > dt-bindings: arm: sunxi: emlid,neutis-n5(-devboard) > > sunxi: add new compatibles for Emlid Neutis Dev board and SoM module > > Signed-off-by: Aleksandr Aleksandrov > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.txt b/Documentation/devicetree/bindings/arm/sunxi.txt > index e4beec3..a907e52 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi.txt > +++ b/Documentation/devicetree/bindings/arm/sunxi.txt > @@ -19,3 +19,5 @@ using one of the following compatible strings: > allwinner,sun9i-a80 > allwinner,sun50i-a64 > nextthing,gr8 > + emlid,neutis-n5 > + emlid,neutis-n5-devboard > > Is this right place for the neutis compatibles? No, those are for SoCs compatible. I'm not sure we ever created a board compatible files. -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com