* [PATCH V2 1/2] dt-bindings: mmc: sdhci-msm: Add new compatible string for sdcdc10 DLL
[not found] <1539005138-32560-1-git-send-email-vbadigan@codeaurora.org>
@ 2018-10-08 13:25 ` Veerabhadrarao Badiganti
2018-10-12 20:48 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Veerabhadrarao Badiganti @ 2018-10-08 13:25 UTC (permalink / raw)
To: adrian.hunter, ulf.hansson, robh+dt, evgreen, dianders
Cc: asutoshd, riteshh, stummala, sayalil, linux-mmc, linux-arm-msm,
Veerabhadrarao Badiganti, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On the SDHC-MSM controllers which makes use of sdcdc10 variant DLLs,
the DLL configuration needs to be restored whenever controller clocks
are gated. This new compatible string denotes the sdhc-msm controller
variant which uses sdcdc10 DLL.
Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
---
Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
index 3720385..49b0a43 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
@@ -6,7 +6,11 @@ and the properties used by the sdhci-msm driver.
Required properties:
- compatible: Should contain:
"qcom,sdhci-msm-v4" for sdcc versions less than 5.0
+ "qcom,sdhci-msm-v4-sdcdc10" for sdcc versions < 5.0 and
+ which makes use of sdcdc10 variant DLLs.
"qcom,sdhci-msm-v5" for sdcc versions >= 5.0
+ "qcom,sdhci-msm-v5-sdcdc10" for sdcc versions >= 5.0 and
+ which makes use of sdcdc10 variant DLLs.
For SDCC version 5.0.0, MCI registers are removed from SDCC
interface and some registers are moved to HC. New compatible
string is added to support this change - "qcom,sdhci-msm-v5".
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: mmc: sdhci-msm: Add new compatible string for sdcdc10 DLL
2018-10-08 13:25 ` [PATCH V2 1/2] dt-bindings: mmc: sdhci-msm: Add new compatible string for sdcdc10 DLL Veerabhadrarao Badiganti
@ 2018-10-12 20:48 ` Rob Herring
2018-11-01 11:54 ` Veerabhadrarao Badiganti
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2018-10-12 20:48 UTC (permalink / raw)
To: Veerabhadrarao Badiganti
Cc: adrian.hunter, ulf.hansson, evgreen, dianders, asutoshd, riteshh,
stummala, sayalil, linux-mmc, linux-arm-msm, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Mon, Oct 08, 2018 at 06:55:37PM +0530, Veerabhadrarao Badiganti wrote:
> On the SDHC-MSM controllers which makes use of sdcdc10 variant DLLs,
> the DLL configuration needs to be restored whenever controller clocks
> are gated. This new compatible string denotes the sdhc-msm controller
> variant which uses sdcdc10 DLL.
What is sdcdc10 DLL?
Seems like a work-around to not having SoC specific compatible strings.
>
> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> ---
> Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> index 3720385..49b0a43 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> @@ -6,7 +6,11 @@ and the properties used by the sdhci-msm driver.
> Required properties:
> - compatible: Should contain:
> "qcom,sdhci-msm-v4" for sdcc versions less than 5.0
> + "qcom,sdhci-msm-v4-sdcdc10" for sdcc versions < 5.0 and
> + which makes use of sdcdc10 variant DLLs.
> "qcom,sdhci-msm-v5" for sdcc versions >= 5.0
> + "qcom,sdhci-msm-v5-sdcdc10" for sdcc versions >= 5.0 and
> + which makes use of sdcdc10 variant DLLs.
> For SDCC version 5.0.0, MCI registers are removed from SDCC
> interface and some registers are moved to HC. New compatible
> string is added to support this change - "qcom,sdhci-msm-v5".
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: mmc: sdhci-msm: Add new compatible string for sdcdc10 DLL
2018-10-12 20:48 ` Rob Herring
@ 2018-11-01 11:54 ` Veerabhadrarao Badiganti
0 siblings, 0 replies; 3+ messages in thread
From: Veerabhadrarao Badiganti @ 2018-11-01 11:54 UTC (permalink / raw)
To: Rob Herring
Cc: adrian.hunter, ulf.hansson, evgreen, dianders, asutoshd, riteshh,
stummala, sayalil, linux-mmc, linux-arm-msm, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 10/13/2018 2:18 AM, Rob Herring wrote:
> On Mon, Oct 08, 2018 at 06:55:37PM +0530, Veerabhadrarao Badiganti wrote:
>> On the SDHC-MSM controllers which makes use of sdcdc10 variant DLLs,
>> the DLL configuration needs to be restored whenever controller clocks
>> are gated. This new compatible string denotes the sdhc-msm controller
>> variant which uses sdcdc10 DLL.
> What is sdcdc10 DLL?
>
> Seems like a work-around to not having SoC specific compatible strings.
Will update this to SOC specific compatible string.
>> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
>> index 3720385..49b0a43 100644
>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
>> @@ -6,7 +6,11 @@ and the properties used by the sdhci-msm driver.
>> Required properties:
>> - compatible: Should contain:
>> "qcom,sdhci-msm-v4" for sdcc versions less than 5.0
>> + "qcom,sdhci-msm-v4-sdcdc10" for sdcc versions < 5.0 and
>> + which makes use of sdcdc10 variant DLLs.
>> "qcom,sdhci-msm-v5" for sdcc versions >= 5.0
>> + "qcom,sdhci-msm-v5-sdcdc10" for sdcc versions >= 5.0 and
>> + which makes use of sdcdc10 variant DLLs.
>> For SDCC version 5.0.0, MCI registers are removed from SDCC
>> interface and some registers are moved to HC. New compatible
>> string is added to support this change - "qcom,sdhci-msm-v5".
>> --
>> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
>>
Thanks
Veera
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-01 11:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1539005138-32560-1-git-send-email-vbadigan@codeaurora.org>
2018-10-08 13:25 ` [PATCH V2 1/2] dt-bindings: mmc: sdhci-msm: Add new compatible string for sdcdc10 DLL Veerabhadrarao Badiganti
2018-10-12 20:48 ` Rob Herring
2018-11-01 11:54 ` Veerabhadrarao Badiganti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).