From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Richard Weinberger <richard@nod.at>,
Marek Vasut <marek.vasut@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mtd@lists.infradead.org, Kumar Gala <galak@codeaurora.org>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 09/14] mtd: maps: physmap: Fix coding style issues reported by checkpatch
Date: Sun, 14 Oct 2018 09:26:38 +0200 [thread overview]
Message-ID: <20181014092638.75cda7ad@bbrezillon> (raw)
In-Reply-To: <20181009095205.7d5cc9d9@bbrezillon>
On Tue, 9 Oct 2018 09:52:05 +0200
Boris Brezillon <boris.brezillon@bootlin.com> wrote:
> > > @@ -163,13 +164,16 @@ static int physmap_flash_probe(struct platform_device *dev)
> > > simple_map_init(&info->maps[i]);
> > >
> > > probe_type = rom_probe_types;
> > > - if (physmap_data->probe_type == NULL) {
> > > - for (; info->mtds[i] == NULL && *probe_type != NULL; probe_type++)
> > > - info->mtds[i] = do_map_probe(*probe_type, &info->maps[i]);
> > > - } else
> > > - info->mtds[i] = do_map_probe(physmap_data->probe_type, &info->maps[i]);
> > > + if (!physmap_data->probe_type) {
> > > + for (; !info->mtds[i] && *probe_type; probe_type++)
> > > + info->mtds[i] = do_map_probe(*probe_type,
> > > + &info->maps[i]);
> > > + } else {
> > > + info->mtds[i] = do_map_probe(physmap_data->probe_type,
> > > + &info->maps[i]);
> > > + }
> >
> > Now that you are at it, maybe you want to change the order of the if branches:
> >
> > if (true){
> > } else{
> > }
> >
> > and move:
> > probe_type = rom_probe_types;
> > into the branch
> >
> > and fix:
> > const char * const *probe_type;
> >
> >
> > If you do not want to change it, is also fine :P
>
> I don't mind changing that, but not in this patch :-).
Actually, I'll let you send a patch on top of my series if you still
want to address that ;-).
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2018-10-14 7:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 20:10 [PATCH 00/14] mtd: maps: physmap cleanups Boris Brezillon
2018-10-08 20:10 ` [PATCH 01/14] mtd: maps: physmap: Add SPDX header Boris Brezillon
2018-10-08 20:10 ` [PATCH 02/14] mtd: maps: physmap: Rename ->map and ->mtd into ->maps and ->mtds Boris Brezillon
2018-10-08 20:10 ` [PATCH 03/14] mtd: maps: physmap: Use platform_get_resource() to retrieve iomem resources Boris Brezillon
2018-10-09 7:16 ` Ricardo Ribalda Delgado
2018-10-09 7:54 ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 04/14] mtd: maps: physmap: Use dev_notice() and a %pR specifier Boris Brezillon
2018-10-08 20:10 ` [PATCH 05/14] mtd: maps: physmap: Use devm_ioremap_resource() Boris Brezillon
2018-10-08 20:10 ` [PATCH 06/14] mtd: maps: physmap: Remove the MAX_RESOURCES limitation Boris Brezillon
2018-10-09 7:31 ` Ricardo Ribalda Delgado
2018-10-09 7:53 ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 07/14] mtd: maps: physmap: Check mtd_device_{parse_register, unregister}() ret code Boris Brezillon
2018-10-08 20:10 ` [PATCH 08/14] mtd: maps: physmap: Return -ENOMEM directly when info allocation fails Boris Brezillon
2018-10-08 20:10 ` [PATCH 09/14] mtd: maps: physmap: Fix coding style issues reported by checkpatch Boris Brezillon
2018-10-09 7:37 ` Ricardo Ribalda Delgado
2018-10-09 7:52 ` Boris Brezillon
2018-10-14 7:26 ` Boris Brezillon [this message]
2018-10-08 20:10 ` [PATCH 10/14] mtd: maps: Prepare merging of physmap and physmap_of Boris Brezillon
2018-10-08 20:10 ` [PATCH 11/14] mtd: maps: Merge physmap_of.c into physmap-core.c Boris Brezillon
2018-10-09 6:58 ` Ricardo Ribalda Delgado
2018-10-09 7:06 ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 12/14] mtd: maps: Merge gpio-addr-flash.c " Boris Brezillon
2018-10-09 7:04 ` Ricardo Ribalda Delgado
2018-10-09 7:11 ` Boris Brezillon
2018-10-14 7:06 ` Boris Brezillon
2018-10-08 20:10 ` [PATCH 13/14] mtd: maps: Rename physmap_of_{versatile, gemini} into physmap-{versatile, gemini} Boris Brezillon
2018-10-08 20:10 ` [PATCH 14/14] dt-binding: mtd: physmap: Document the addr-gpios property Boris Brezillon
2018-10-09 7:43 ` Ricardo Ribalda Delgado
2018-10-09 7:56 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181014092638.75cda7ad@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=ricardo.ribalda@gmail.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).