From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Mylene JOSSERAND <mylene.josserand@free-electrons.com>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Marcus Cooper <codekipper@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v4 0/9] Add support for audiocodec in Allwinner A64
Date: Tue, 16 Oct 2018 13:49:45 +0200 [thread overview]
Message-ID: <20181016114945.ghigmd5oxm2je7jc@flea> (raw)
In-Reply-To: <CA+E=qVdA06n3Q=UP_gp05Ah2tf2UC-hOUCS471D_D6d2v-yF2A@mail.gmail.com>
On Tue, Oct 16, 2018 at 12:13:26AM -0700, Vasily Khoruzhick wrote:
> On Tue, Oct 16, 2018, 00:09 Maxime Ripard <[1]maxime.ripard@bootlin.com> wrote:
>
> Hi,
>
> On Mon, Oct 15, 2018 at 08:02:30PM -0700, Vasily Khoruzhick wrote:
> > This series adds Allwinner A64 audiocodec support into sun4i-i2s,
> > sun8i-codec drivers, introduces new sun50i-codec-analog driver and
> enables
> > sound on Pine64, SoPine boards and Pinebook.
> >
> > I2S for audiocodec in A64 is different from other 3 I2S modules but
> > similar to one in A10, digital part of codec is compatible with A33 and
> > analog controls part is completely different from other SoCs - it shares
> > only few bits in few registers, so adding support for it into existing
> > sun8i-codec-analog would mean duplicating all the widgets, controls and
> > some routes and making it hard to read. Therefore it makes sense to
> > introduce new driver.
> >
> > v2: - Use simple-amplifier for speaker amp on Pinebook
> > - Rename sun50i-a64-i2s to sun50i-a64-codec-i2s to preserve
> compatible
> > string for other 3 I2S modules in A64 in case if there's any
> > incompatibility with H3
> > v3: - renamed sunxi-adda-pr-regmap to sun8i-adda-pr-regmap
> > - use ilog2() to calculate reg value for LRCK div instead of using a
> > table
> > v4: - dts: don't use 'Mic' and 'Headset Mic' widgets from sun8i-codec,
> > define our board-level widgets instead.
>
> You also need to collect the tags that are given by the various people
> involved in that review :)
>
>
> My bad. Do you want me to send v5 with all the tags?
Yep, please, thankS!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-10-16 11:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 3:02 [PATCH v4 0/9] Add support for audiocodec in Allwinner A64 Vasily Khoruzhick
2018-10-16 3:02 ` [PATCH v4 1/9] ASoC: sun4i-i2s: Add compatibility with A64 codec I2S Vasily Khoruzhick
2018-10-16 3:02 ` [PATCH v4 2/9] ASoC: sun8i-codec: Don't hardcode BCLK / LRCK ratio Vasily Khoruzhick
2018-10-17 7:12 ` Maxime Ripard
2018-10-17 7:17 ` Vasily Khoruzhick
2018-10-16 3:02 ` [PATCH v4 3/9] ASoC: sun8i-codec-analog: split regmap code into separate driver Vasily Khoruzhick
2018-10-16 3:02 ` [PATCH v4 4/9] ASoC: dt-binding: Add bindings for Allwinner A64 codec's analog path controls Vasily Khoruzhick
2018-10-16 3:02 ` [PATCH v4 5/9] ASoC: sunxi: Add new driver " Vasily Khoruzhick
2018-10-16 3:02 ` [PATCH v4 6/9] ASoC: sunxi: allow the sun8i-codec driver to be built on ARM64 Vasily Khoruzhick
2018-10-16 3:02 ` [PATCH v4 7/9] arm64: dts: allwinner: a64: add nodes necessary for analog sound support Vasily Khoruzhick
2018-10-16 3:02 ` [PATCH v4 8/9] arm64: dts: allwinner: a64: enable sound on Pine64 and SoPine Vasily Khoruzhick
2018-10-16 3:02 ` [PATCH v4 9/9] arm64: dts: allwinner: a64: enable sound on Pinebook Vasily Khoruzhick
2018-10-16 7:08 ` [PATCH v4 0/9] Add support for audiocodec in Allwinner A64 Maxime Ripard
2018-10-16 7:13 ` Vasily Khoruzhick
2018-10-16 11:49 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016114945.ghigmd5oxm2je7jc@flea \
--to=maxime.ripard@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=anarsoul@gmail.com \
--cc=broonie@kernel.org \
--cc=codekipper@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mylene.josserand@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox