From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/2] dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1 Date: Wed, 17 Oct 2018 10:23:54 -0500 Message-ID: <20181017152354.GA9268@bogus> References: <3a1a95a4832af33dcd1842b0298d257bbcf1f5ab.1539036280.git.gustavo@embeddedor.com> <20181009072723.mshyvplpo2xmkyfl@qschulz> <20181017150931.GA385@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181017150931.GA385@bogus> Sender: linux-kernel-owner@vger.kernel.org To: "Gustavo A. R. Silva" Cc: Quentin Schulz , Mark Rutland , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Wed, Oct 17, 2018 at 10:09:31AM -0500, Rob Herring wrote: > On Tue, Oct 16, 2018 at 10:44:52AM +0200, Gustavo A. R. Silva wrote: > > Hi, > > > > On 10/9/18 9:27 AM, Quentin Schulz wrote: > > > Hi Gustavo, > > > > > > On Tue, Oct 09, 2018 at 12:21:36AM +0200, Gustavo A. R. Silva wrote: > > >> SERDES_MAX is a valid value to index ctrl->phys in > > >> drivers/phy/mscc/phy-ocelot-serdes.c. But, currently, > > >> there is an out-of-bounds bug in the mentioned driver > > >> when reading from ctrl->phys, because the size of > > >> array ctrl->phys is SERDES_MAX. > > >> > > >> Partially fix this by updating SERDES_MAX to be SERDES6G_MAX + 1. > > >> > > >> Notice that this is the first part of the solution to > > >> the out-of-bounds bug mentioned above. Although this > > >> change is not dependent on any other one. > > >> > > > > > > Reviewed-by: Quentin Schulz > > > > > > > Friendly ping. Who can you take this? > > Applied. No need (nor benefit) to ping me. You can check the status of > DT patches on patchwork[1]. If it is there and in the "New" state, it is > in my queue. Actually, this doesn't apply to my tree as the file doesn't exist. It needs to go thru the phy tree. You didn't Cc the maintainer nor list, so resend. Acked-by: Rob Herring Rob