From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [RFC PATCH 02/11] dt-bindings: phy: add cpsw port interface mode selection phy bindings Date: Wed, 17 Oct 2018 10:39:13 -0500 Message-ID: <20181017153913.GA13333@bogus> References: <20181008234949.15416-1-grygorii.strashko@ti.com> <20181008234949.15416-3-grygorii.strashko@ti.com> <20181009144000.GL5662@atomide.com> <3fa09831-0f70-dfcc-3fd9-f877215a4631@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <3fa09831-0f70-dfcc-3fd9-f877215a4631@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Grygorii Strashko Cc: Tony Lindgren , "David S. Miller" , netdev@vger.kernel.org, Kishon Vijay Abraham I , Sekhar Nori , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Tue, Oct 09, 2018 at 03:10:34PM -0500, Grygorii Strashko wrote: > > > On 10/09/2018 09:40 AM, Tony Lindgren wrote: > > * Grygorii Strashko [181008 23:54]: > >> +Examples: > >> + phy_gmii_sel: phy-gmii-sel { > >> + compatible = "ti,am3352-phy-gmii-sel"; > >> + syscon-scm = <&scm_conf>; > >> + #phy-cells = <2>; > >> + }; > > > > Now that this driver can live in it's proper place in the > > right > > > dts, you may want to consider just using standard reg > > property for it instead of the syscon-scm. And also get > > rid of the syscon reads and writes. > > Could you help clarify how to get syscon in this case? > syscon_node_to_regmap(dev->parent->of_node)? > > Also, there are could be more then one gmii_sel registers in SCM in the future, > so I hidden offsets in of_match data. > As result, "reg" not needed at all now. If there's a defined register range which doesn't overlap with other things (other than the parent), then use reg whether you currently need it or not. Rob