From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 1/7] dt-bindings: virtio-mmio: Add IOMMU description Date: Wed, 17 Oct 2018 19:30:51 -0500 Message-ID: <20181018003051.GA3400@bogus> References: <20181012145917.6840-1-jean-philippe.brucker@arm.com> <20181012145917.6840-2-jean-philippe.brucker@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20181012145917.6840-2-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Jean-Philippe Brucker Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, peter.maydell-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, tnowicki-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, marc.zyngier-5wv7dgnIgG8@public.gmane.org, robin.murphy-5wv7dgnIgG8@public.gmane.org, kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Oct 12, 2018 at 03:59:11PM +0100, Jean-Philippe Brucker wrote: > The nature of a virtio-mmio node is discovered by the virtio driver at > probe time. However the DMA relation between devices must be described > statically. When a virtio-mmio node is a virtio-iommu device, it needs an > "#iommu-cells" property as specified by bindings/iommu/iommu.txt. > > Otherwise, the virtio-mmio device may perform DMA through an IOMMU, which > requires an "iommus" property. Describe these requirements in the > device-tree bindings documentation. > > Signed-off-by: Jean-Philippe Brucker > --- > .../devicetree/bindings/virtio/mmio.txt | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) One nit, otherwise, Reviewed-by: Rob Herring > > diff --git a/Documentation/devicetree/bindings/virtio/mmio.txt b/Documentation/devicetree/bindings/virtio/mmio.txt > index 5069c1b8e193..748595473b36 100644 > --- a/Documentation/devicetree/bindings/virtio/mmio.txt > +++ b/Documentation/devicetree/bindings/virtio/mmio.txt > @@ -8,10 +8,40 @@ Required properties: > - reg: control registers base address and size including configuration space > - interrupts: interrupt generated by the device > > +Required properties for virtio-iommu: > + > +- #iommu-cells: When the node corresponds to a virtio-iommu device, it is > + linked to DMA masters using the "iommus" or "iommu-map" > + properties [1][2]. #iommu-cells specifies the size of the > + "iommus" property. For virtio-iommu #iommu-cells must be > + 1, each cell describing a single endpoint ID. > + > +Optional properties: > + > +- iommus: If the device accesses memory through an IOMMU, it should > + have an "iommus" property [1]. Since virtio-iommu itself > + does not access memory through an IOMMU, the "virtio,mmio" > + node cannot have both an "#iommu-cells" and an "iommus" > + property. > + > Example: > > virtio_block@3000 { > compatible = "virtio,mmio"; > reg = <0x3000 0x100>; > interrupts = <41>; > + > + /* Device has endpoint ID 23 */ > + iommus = <&viommu 23> > } > + > + viommu: virtio_iommu@3100 { iommu@3100 > + compatible = "virtio,mmio"; > + reg = <0x3100 0x100>; > + interrupts = <42>; > + > + #iommu-cells = <1> > + } > + > +[1] Documentation/devicetree/bindings/iommu/iommu.txt > +[2] Documentation/devicetree/bindings/pci/pci-iommu.txt > -- > 2.19.1 >