From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guo Ren Subject: Re: [PATCH V9 12/21] csky: ELF and module probe Date: Thu, 18 Oct 2018 10:49:30 +0800 Message-ID: <20181018024929.GC13314@guoren-Inspiron-7460> References: <27589f69f513177892d39868050dccb5f21023aa.1539655732.git.ren_guo@c-sky.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Andrew Morton , Daniel Lezcano , David Miller , gregkh , Christoph Hellwig , Marc Zyngier , Mark Rutland , Peter Zijlstra , Rob Herring , Thomas Gleixner , Linux Kernel Mailing List , linux-arch , DTML , Rob Herring , c-sky_gcc_upstream@c-sky.com List-Id: devicetree@vger.kernel.org On Wed, Oct 17, 2018 at 05:18:49PM +0200, Arnd Bergmann wrote: > On Tue, Oct 16, 2018 at 5:02 AM Guo Ren wrote: > > > > This patch adds ELF definition and module relocate codes. > > > > Signed-off-by: Guo Ren > > Cc: Arnd Bergmann > > > +#ifdef __cskyBE__ > > +#define ELF_DATA ELFDATA2MSB > > +#else > > +#define ELF_DATA ELFDATA2LSB > > +#endif > > You removed support for big-endian, right? I guess the #ifdef can also > get removed here then. Aside from that, Now, we only support little-endian and it could be removed. But maybe we need support big-endian in future, so I keep it here. Best Regards Guo Ren