From: Rob Herring <robh@kernel.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "Lars Poeschel" <poeschel@lemonage.de>,
devicetree <devicetree@vger.kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Peter Rosin" <peda@axentia.se>,
"Vadim Pasternak" <vadimp@mellanox.com>,
"Lei YU" <mine260309@gmail.com>,
"Andreas Färber" <afaerber@suse.de>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] nfc: pn532_uart: Add NXP PN532 to devicetree docs
Date: Thu, 18 Oct 2018 15:41:29 -0500 [thread overview]
Message-ID: <20181018204129.GA25436@bogus> (raw)
In-Reply-To: <F2B73CDB-434A-41F5-8A9E-3E4E76DB89C9@holtmann.org>
On Thu, Oct 18, 2018 at 05:03:13PM +0200, Marcel Holtmann wrote:
> Hi Lars,
>
> > Add pn532 to the trivial-devices.txt binding doc.
> >
> > Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> > ---
> > Documentation/devicetree/bindings/trivial-devices.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt
> > index 763a2808a95c..c580be08a380 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.txt
> > +++ b/Documentation/devicetree/bindings/trivial-devices.txt
> > @@ -172,6 +172,7 @@ nxp,pcf2129 Real-time clock
> > nxp,pcf8523 Real-time Clock
> > nxp,pcf8563 Real-time clock/calendar
> > nxp,pcf85063 Tiny Real-Time Clock
> > +nxp,pn532-uart NXP PN532 NFC-/RFID-Chip, using UART interface
>
> is this really such a trivial device? It doesn’t require any GPIO to enable / reset the NFC chip?
Considering it supports multiple interfaces, it is not.
The '-uart' can be dropped and the same compatible used for any
of the bus connections because the device is bound based on the bus
type.
Rob
next prev parent reply other threads:[~2018-10-18 20:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 14:42 [PATCH v2 1/4] nfc: pn533: add UART phy driver Lars Poeschel
2018-10-18 14:42 ` [PATCH v2 2/4] nfc: pn532_uart: Add NXP PN532 to devicetree docs Lars Poeschel
2018-10-18 15:03 ` Marcel Holtmann
2018-10-18 20:41 ` Rob Herring [this message]
2018-10-19 9:12 ` Lars Poeschel
2018-10-18 14:42 ` [PATCH v2 3/4] nfc: pn533: Add autopoll capability Lars Poeschel
[not found] ` <20181018144251.30028-1-poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org>
2018-10-18 14:42 ` [PATCH v2 4/4] nfc: pn532_uart: Make use of pn532 autopoll Lars Poeschel
2018-10-18 15:00 ` [PATCH v2 1/4] nfc: pn533: add UART phy driver Marcel Holtmann
2018-10-19 8:57 ` Lars Poeschel
2018-10-20 9:27 ` Johan Hovold
2018-10-25 13:28 ` Lars Poeschel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018204129.GA25436@bogus \
--to=robh@kernel.org \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=mine260309@gmail.com \
--cc=peda@axentia.se \
--cc=poeschel@lemonage.de \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).