From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 2/4] nfc: pn532_uart: Add NXP PN532 to devicetree docs Date: Thu, 18 Oct 2018 15:41:29 -0500 Message-ID: <20181018204129.GA25436@bogus> References: <20181018144251.30028-1-poeschel@lemonage.de> <20181018144251.30028-2-poeschel@lemonage.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Marcel Holtmann Cc: Lars Poeschel , devicetree , Mark Rutland , Peter Rosin , Vadim Pasternak , Lei YU , Andreas =?iso-8859-1?Q?F=E4rber?= , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , open list List-Id: devicetree@vger.kernel.org On Thu, Oct 18, 2018 at 05:03:13PM +0200, Marcel Holtmann wrote: > Hi Lars, > > > Add pn532 to the trivial-devices.txt binding doc. > > > > Signed-off-by: Lars Poeschel > > --- > > Documentation/devicetree/bindings/trivial-devices.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt > > index 763a2808a95c..c580be08a380 100644 > > --- a/Documentation/devicetree/bindings/trivial-devices.txt > > +++ b/Documentation/devicetree/bindings/trivial-devices.txt > > @@ -172,6 +172,7 @@ nxp,pcf2129 Real-time clock > > nxp,pcf8523 Real-time Clock > > nxp,pcf8563 Real-time clock/calendar > > nxp,pcf85063 Tiny Real-Time Clock > > +nxp,pn532-uart NXP PN532 NFC-/RFID-Chip, using UART interface > > is this really such a trivial device? It doesn’t require any GPIO to enable / reset the NFC chip? Considering it supports multiple interfaces, it is not. The '-uart' can be dropped and the same compatible used for any of the bus connections because the device is bound based on the bus type. Rob