From: Johan Hovold <johan@kernel.org>
To: Lars Poeschel <poeschel@lemonage.de>
Cc: Marcel Holtmann <marcel@holtmann.org>,
devicetree@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:NFC SUBSYSTEM" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] nfc: pn533: add UART phy driver
Date: Sat, 20 Oct 2018 11:27:33 +0200 [thread overview]
Message-ID: <20181020092733.GV3383@localhost> (raw)
In-Reply-To: <20181019085728.GA26696@lem-wkst-02.lemonage>
On Fri, Oct 19, 2018 at 10:57:28AM +0200, Lars Poeschel wrote:
> On Thu, Oct 18, 2018 at 05:00:28PM +0200, Marcel Holtmann wrote:
> > > --- a/drivers/nfc/pn533/Kconfig
> > > +++ b/drivers/nfc/pn533/Kconfig
> > > @@ -25,3 +25,13 @@ config NFC_PN533_I2C
> > >
> > > If you choose to build a module, it'll be called pn533_i2c.
> > > Say N if unsure.
> > > +
> > > +config NFC_PN532_UART
> > > + tristate "NFC PN532 device support (UART)”
> >
> > you are missing the "depends on SERIAL_DEV_BUS” here.
>
> Yes, absolutely right. I missed that. I will post a follow-up.
>
> BTW a question:
> Only enabling SERIAL_DEV_BUS did not suffice for me. I also had to
> enable SERIAL_DEV_CTRL_TTYPORT, otherwise the probe of the driver was
> not called. This seems a bit odd to me. This option seems unrelated, but
> without it, it did not work.
>
> Should I better depend on SERIAL_DEV_CTRL_TTYPORT then ?
No, SERIAL_DEV_BUS is the correct (build-time) dependency.
In principle, your driver will work with any serdev-controller
implementation even if we currently only have one of those in the kernel
(and SERIAL_DEV_CTRL_TTYPORT therefore default to Y whenever
SERIAL_DEV_BUS is selected).
Johan
next prev parent reply other threads:[~2018-10-20 9:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 14:42 [PATCH v2 1/4] nfc: pn533: add UART phy driver Lars Poeschel
2018-10-18 14:42 ` [PATCH v2 2/4] nfc: pn532_uart: Add NXP PN532 to devicetree docs Lars Poeschel
2018-10-18 15:03 ` Marcel Holtmann
2018-10-18 20:41 ` Rob Herring
2018-10-19 9:12 ` Lars Poeschel
2018-10-18 14:42 ` [PATCH v2 3/4] nfc: pn533: Add autopoll capability Lars Poeschel
[not found] ` <20181018144251.30028-1-poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org>
2018-10-18 14:42 ` [PATCH v2 4/4] nfc: pn532_uart: Make use of pn532 autopoll Lars Poeschel
2018-10-18 15:00 ` [PATCH v2 1/4] nfc: pn533: add UART phy driver Marcel Holtmann
2018-10-19 8:57 ` Lars Poeschel
2018-10-20 9:27 ` Johan Hovold [this message]
2018-10-25 13:28 ` Lars Poeschel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181020092733.GV3383@localhost \
--to=johan@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=poeschel@lemonage.de \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).