From: Brian Masney <masneyb@onstation.org>
To: Rob Herring <robh@kernel.org>
Cc: andy.gross@linaro.org, sre@kernel.org, mark.rutland@arm.com,
david.brown@linaro.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
jonathan@marek.ca
Subject: Re: [PATCH RFC 1/5] dt-bindings: power: supply: bq24190_charger: add bq24192 and usb-otg-vbus
Date: Mon, 22 Oct 2018 20:04:39 -0400 [thread overview]
Message-ID: <20181023000439.neadgrmsyg2t6da4@38e519447dc0> (raw)
In-Reply-To: <20181015185252.GA8056@bogus>
Hi Rob,
On Mon, Oct 15, 2018 at 01:52:52PM -0500, Rob Herring wrote:
> On Mon, Oct 01, 2018 at 01:30:01AM -0400, Brian Masney wrote:
> > Add support for the ti,bq24192 variant and a child node for the
> > usb-otg-vbus regulator.
> >
> > Signed-off-by: Brian Masney <masneyb@onstation.org>
> > ---
> > Documentation/devicetree/bindings/power/supply/bq24190.txt | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/bq24190.txt b/Documentation/devicetree/bindings/power/supply/bq24190.txt
> > index 9e517d307070..8f2560824a97 100644
> > --- a/Documentation/devicetree/bindings/power/supply/bq24190.txt
> > +++ b/Documentation/devicetree/bindings/power/supply/bq24190.txt
> > @@ -3,6 +3,7 @@ TI BQ24190 Li-Ion Battery Charger
> > Required properties:
> > - compatible: contains one of the following:
> > * "ti,bq24190"
> > + * "ti,bq24192"
> > * "ti,bq24192i"
> > - reg: integer, I2C address of the charger.
> > - interrupts[-extended]: configuration for charger INT pin.
> > @@ -19,6 +20,12 @@ Optional properties:
> > - ti,system-minimum-microvolt: when power is connected and the battery is below
> > minimum system voltage, the system will be regulated above this setting.
> >
> > +child nodes:
> > +- usb-otg-vbus:
> > + Usage: optional
> > + Description: Regulator that is used to control the VBUS voltage direction for
> > + either USB host mode or for charging on the OTG port.
>
> What about the regulator properties?
There are no regulator properties underneath this child node. This is a
similar setup to what is described in
Documentation/devicetree/bindings/power/supply/qcom_smbb.txt.
If this is the correct way to do this, then perhaps I can add the
usb_otg_vbus node to the example in v2.
Brian
> > +
> > Notes:
> > - Some circuit boards wire the chip's "OTG" pin high (enabling 500mA default
> > charge current on USB SDP ports, among other features). To simulate this on
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2018-10-23 0:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 5:30 [PATCH RFC 0/5] treewide: add USB OTG support for hammerhead Brian Masney
2018-10-01 5:30 ` [PATCH RFC 1/5] dt-bindings: power: supply: bq24190_charger: add bq24192 and usb-otg-vbus Brian Masney
2018-10-15 18:52 ` Rob Herring
2018-10-23 0:04 ` Brian Masney [this message]
2018-10-01 5:30 ` [PATCH RFC 2/5] power: supply: bq24190_charger: add support for bq24192 variant Brian Masney
2018-10-21 22:17 ` Sebastian Reichel
2018-10-01 5:30 ` [PATCH RFC 3/5] power: supply: bq24190_charger: add of_match for usb-otg-vbus regulator Brian Masney
2018-10-01 5:30 ` [PATCH RFC 4/5] power: supply: bq24190_charger: add support for extcon and GPIO for USB OTG support Brian Masney
2018-10-01 5:30 ` [PATCH RFC 5/5] ARM: dts: qcom: msm8974-hammerhead: add " Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023000439.neadgrmsyg2t6da4@38e519447dc0 \
--to=masneyb@onstation.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).