From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 2/4] drm/panel: simple: Add support for the Lemaker BL035 3.5" LCD Date: Wed, 24 Oct 2018 17:57:59 +0100 Message-ID: <20181024165759.k6cnxyzgpiiuaigs@flea> References: <20181010114134.8211-1-contact@paulk.fr> <20181010114134.8211-2-contact@paulk.fr> <20181010145850.krwe7wlqkbcpja33@flea> <30178c8b263656a9c285e45c78e1908927c99c48.camel@paulk.fr> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <30178c8b263656a9c285e45c78e1908927c99c48.camel-W9ppeneeCTY@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Paul Kocialkowski Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Rob Herring , Mark Rutland , Chen-Yu Tsai , Thierry Reding , David Airlie , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Mark Van den Borre , Gerry Demaret , Luc Verhaegen List-Id: devicetree@vger.kernel.org On Tue, Oct 23, 2018 at 12:08:17PM +0200, Paul Kocialkowski wrote: > Hi, >=20 > Le mercredi 10 octobre 2018 =C3=A0 16:58 +0200, Maxime Ripard a =C3=A9cri= t : > > On Wed, Oct 10, 2018 at 01:41:32PM +0200, Paul Kocialkowski wrote: > > > This adds support for the 3.5" LCD panel from Lemaker, sold for use w= ith > > > BananaPi boards. It comes with a 24-bit RGB888 parallel interface and > > > requires an active-low DE signal > > >=20 > > > Signed-off-by: Paul Kocialkowski > > > --- > > > drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++++++= + > > > 1 file changed, 27 insertions(+) > > >=20 > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/p= anel/panel-simple.c > > > index 97964f7f2ace..229080fcf65e 100644 > > > --- a/drivers/gpu/drm/panel/panel-simple.c > > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > > @@ -1461,6 +1461,30 @@ static const struct panel_desc kyo_tcg121xglp = =3D { > > > .bus_format =3D MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, > > > }; > > > =20 > > > +static const struct drm_display_mode lemaker_bl035_mode =3D { > > > + .clock =3D 7000, > > > + .hdisplay =3D 320, > > > + .hsync_start =3D 320 + 20, > > > + .hsync_end =3D 320 + 20 + 30, > > > + .htotal =3D 320 + 20 + 30 + 38, > > > + .vdisplay =3D 240, > > > + .vsync_start =3D 240 + 4, > > > + .vsync_end =3D 240 + 4 + 3, > > > + .vtotal =3D 240 + 4 + 3 + 15, > > > + .vrefresh =3D 60, > > > +}; > > > + > > > +static const struct panel_desc lemaker_bl035 =3D { > > > + .modes =3D &lemaker_bl035_mode, > > > + .num_modes =3D 1, > > > + .size =3D { > > > + .width =3D 70, > > > + .height =3D 52, > > > + }, > > > + .bus_format =3D MEDIA_BUS_FMT_RGB888_1X24, > > > + .bus_flags =3D DRM_BUS_FLAG_DE_LOW, > > > +}; > > > + > > > static const struct drm_display_mode lg_lb070wv8_mode =3D { > > > .clock =3D 33246, > > > .hdisplay =3D 800, > > > @@ -2456,6 +2480,9 @@ static const struct of_device_id platform_of_ma= tch[] =3D { > > > }, { > > > .compatible =3D "kyo,tcg121xglp", > > > .data =3D &kyo_tcg121xglp, > > > + }, { > > > + .compatible =3D "lemaker,bl035", > > > + .data =3D &lemaker_bl035, > >=20 > > You should document that new compatible. Also, where is this name > > coming from? Is it the name it's sold under? something you came up > > with? >=20 > Oh right, I forgot to document the compatible (and add the new vendor). >=20 > The name "BL035" comes from the PCB itself, where it reads "BL035-RGB- > 002" under the Lemaker logo. I went for "BL035" to keep it short. >=20 > The latter part seems to be the PCB revision. According to the fex > files[0], the timings are the same for all the screens of the same size > (regardless of revision), so that revision probably shouldn't be in the > panel name. >=20 > As for the "RGB" part, Lemaker only makes 3.5 and 5 inch LCDs with a > parallel RGB interface and 7 and 10.1 inch LCDs with LVDS, so there is > no ambiguity for now. >=20 > Do you think it makes sense to keep that part in the panel name > nevertheless? I'd just put the full reference, to be on the safe side. Thanks! Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.