From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add device node for Mali-400 GPU Date: Wed, 24 Oct 2018 18:07:09 +0100 Message-ID: <20181024170709.m4s4x3o6qfr4mdbs@flea> References: <20181023161203.2956-1-jagan@amarulasolutions.com> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20181023161203.2956-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Jagan Teki Cc: Chen-Yu Tsai , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Oct 23, 2018 at 09:42:03PM +0530, Jagan Teki wrote: > Add support for Allwinner A64 has Mali-400MP2. > > All interrupt lines are mentioned in the manual so used the same. > Used 408MHz as assigned clock rate used by BSP, so used the same as > well. > > Signed-off-by: Jagan Teki > --- > Note: > - Modules was able to load it on 4.19. > > .../bindings/gpu/arm,mali-utgard.txt | 1 + > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 25 +++++++++++++++++++ > 2 files changed, 26 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt > index 63cd91176a68..a0ee62a5b221 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt > @@ -11,6 +11,7 @@ Required properties: > + allwinner,sun4i-a10-mali > + allwinner,sun7i-a20-mali > + allwinner,sun8i-h3-mali > + + allwinner,sun50i-a64-mali > + allwinner,sun50i-h5-mali > + amlogic,meson-gxbb-mali > + amlogic,meson-gxl-mali Please make a separate patch for this change. > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index f82e6b165d57..2db3aa151902 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -812,6 +812,31 @@ > }; > }; > > + mali: gpu@1c40000 { > + compatible = "allwinner,sun50i-a64-mali", "arm,mali-400"; > + reg = <0x01c40000 0x10000>; > + interrupts = , > + , > + , > + , > + , > + , > + ; > + interrupt-names = "gp", > + "gpmmu", > + "pp0", > + "ppmmu0", > + "pp1", > + "ppmmu1", > + "pmu"; > + clocks = <&ccu CLK_BUS_GPU>, <&ccu CLK_GPU>; > + clock-names = "bus", "core"; > + resets = <&ccu RST_BUS_GPU>; > + > + assigned-clocks = <&ccu CLK_GPU>; > + assigned-clock-rates = <408000000>; This is not needed and should be done in the driver. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com