From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding Date: Thu, 25 Oct 2018 13:30:03 -0500 Message-ID: <20181025183003.GA12672@bogus> References: <20181018073327.64942-1-icenowy@aosc.io> <1886367.eljNk7jKYl@avalon> <2778638.na8ndVNUfi@avalon> Reply-To: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Icenowy Zheng Cc: Laurent Pinchart , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Archit Taneja , David Airlie , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Andrzej Hajda , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Maxime Ripard , Chen-Yu Tsai , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Oct 18, 2018 at 08:40:11PM +0800, Icenowy Zheng wrote: > =E5=9C=A8 2018-10-18=E5=9B=9B=E7=9A=84 14:23 +0300=EF=BC=8CLaurent Pincha= rt=E5=86=99=E9=81=93=EF=BC=9A > > Hi Icenowy, > >=20 > > On Thursday, 18 October 2018 13:00:05 EEST Icenowy Zheng wrote: > > > =E5=9C=A8 2018-10-18=E5=9B=9B=E7=9A=84 11:53 +0300=EF=BC=8CLaurent Pi= nchart=E5=86=99=E9=81=93=EF=BC=9A > > > > On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote: > > > > > The ANX6345 is an ultra-low power DisplayPort/eDP transmitter > > > > > designed > > > > > for portable devices. > > > > >=20 > > > > > Add a binding document for it. > > > > >=20 > > > > > Signed-off-by: Icenowy Zheng > > > > > --- > > > > >=20 > > > > > .../bindings/display/bridge/anx6345.txt | 39 > > > > > +++++++++++++++++++ > > > > >=20 > > > > > 1 file changed, 39 insertions(+) > > > > > create mode 100644 > > > > >=20 > > > > > Documentation/devicetree/bindings/display/bridge/anx6345.txt > > > > >=20 > > > > > diff --git > > > > > a/Documentation/devicetree/bindings/display/bridge/anx6345.txt > > > > > b/Documentation/devicetree/bindings/display/bridge/anx6345.txt > > > > > new > > > > > file > > > > > mode 100644 > > > > > index 000000000000..0689d4eb5f65 > > > > > --- /dev/null > > > > > +++ > > > > > b/Documentation/devicetree/bindings/display/bridge/anx6345.txt > > > > > @@ -0,0 +1,39 @@ > > > > > +Analogix ANX6345 eDP Transmitter > > > > > +-------------------------------- > > > > > + > > > > > +The ANX6345 is an ultra-low power Full-HD eDP transmitter > > > > > designed > > > > > for > > > > > +portable devices. > > > > > + > > > > > +Required properties: > > > > > + > > > > > + - compatible : "analogix,anx6345" > > > > > + - reg : I2C address of the device > > > > > + - reset-gpios : Which GPIO to use for reset > > > > > + > > > > > +Optional properties: > > > > > + > > > > > + - dvdd12-supply : Regulator for 1.2V digital core > > > > > power. > > > > > + - dvdd25-supply : Regulator for 2.5V digital core > > > > > power. > > > >=20 > > > > Shouldn't these to supplies be mandatory ? > > >=20 > > > Yes they should. > > >=20 > > > > > + - panel-supply : Regulator for the power of > > > > > the panel. > > > >=20 > > > > Shouldn't the panel supply for specified in the DT node of the > > > > panel > > > > ? > > >=20 > > > However, eDP panel can be probed, may vary on the same device, and > > > we > > > don't have a generic binding for it... > >=20 > > Shouldn't we fix that ? :-) >=20 > Maybe we should create a connector binding instead of a panel binding? There's not any such thing as a standard eDP connector, is there?=20 Otherwise, that's just creating a generic panel binding in disguise.=20 Maybe if eDP interface is standardized enough in terms of power control,=20 control lines, EDID at least sometimes present, etc., then we could have=20 some sort of generic eDP panel/connector binding. Rob --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.