From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697 Date: Fri, 26 Oct 2018 10:37:04 +0200 Message-ID: <20181026083703.GB19434@amd> References: <20181023170623.31820-1-dmurphy@ti.com> <20181023170623.31820-2-dmurphy@ti.com> <20181024090421.GB24997@amd> <20181024145434.GC9327@bogus> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vGgW1X5XWziG23Ko" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jacek Anaszewski Cc: Dan Murphy , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, lee.jones@linaro.org, tony@atomide.com List-Id: devicetree@vger.kernel.org --vGgW1X5XWziG23Ko Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > Do you have an opinion on this? >=20 > This is this problem with the Device Tree's scope of responsibility. > It is defined as a means for "describing the hardware", but often > this rule is abused by the properties that fall into "configuration" > category. E.g. default-state, retain-state-suspended from leds-gpio.txt > or linux-default-trigger from common LED bindings. "retain-state-suspended" is actually hardware property. On PCs, (most?) LEDs will go off in suspend. On android phones, LEDs stay on while suspended. "linux-default-trigger" is actually kind-of hardware property, too. If LED has an icon near it (or on it), you want to use that LED in that meaning. (Thinkpad X60 has "wifi", "bluetooth", "numlock", "capslock", "hdd", "power", "battery", "ac" and "sleep" leds. Surely we should use them in that meaning?) Now, if someone has leds labeled "user 1..user 4" and uses "linux-default-trigger" there, that is kind of "more interesting". "default-state" is similar (subset of "linux-default-trigger"); you don't want power LED to go off during kernel boot... Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --vGgW1X5XWziG23Ko Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlvS0i8ACgkQMOfwapXb+vLjqACgjatlZKxvDsh7s57Ak6QfTOGa VkUAn1MXdUw/FDBlf5gkAg9UxkandULr =iBxY -----END PGP SIGNATURE----- --vGgW1X5XWziG23Ko--