devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Denis CIOCCA <denis.ciocca@st.com>
Cc: Martin Kelly <martin@martingkelly.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 1/4] iio: magnetometer: add clarifying comment
Date: Sun, 28 Oct 2018 18:45:05 +0000	[thread overview]
Message-ID: <20181028184505.5c6cb5fe@archlinux> (raw)
In-Reply-To: <405cfbe9c82c430682409372aaea4f21@SFHDAG2NODE1.st.com>

On Fri, 26 Oct 2018 18:24:41 +0000
Denis CIOCCA <denis.ciocca@st.com> wrote:

> Hi Martin,
> 
> All the series [v2 / 4 patches] looks good to me. Thanks
> 

Formal Acked-by / Reviewed-by?

Thanks,

Jonathan

> Denis
> 
> 
> -----Original Message-----
> From: Martin Kelly <martin@martingkelly.com> 
> Sent: Thursday, October 25, 2018 7:38 PM
> To: linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>; Denis CIOCCA <denis.ciocca@st.com>; Jonathan Cameron <jic23@kernel.org>; Rob Herring <robh+dt@kernel.org>; Martin Kelly <martin@martingkelly.com>
> Subject: [PATCH v2 1/4] iio: magnetometer: add clarifying comment
> 
> From: Martin Kelly <martin@martingkelly.com>
> 
> Add a comment clarifying better when to use <device_name> vs <device_name>-magn in compatibility strings.
> 
> Signed-off-by: Martin Kelly <martin@martingkelly.com>
> ---
>  drivers/iio/magnetometer/st_magn_spi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/magnetometer/st_magn_spi.c b/drivers/iio/magnetometer/st_magn_spi.c
> index 7b7cd08fcc32..15bb09267098 100644
> --- a/drivers/iio/magnetometer/st_magn_spi.c
> +++ b/drivers/iio/magnetometer/st_magn_spi.c
> @@ -23,6 +23,8 @@
>   * For new single-chip sensors use <device_name> as compatible string.
>   * For old single-chip devices keep <device_name>-magn to maintain
>   * compatibility
> + * For multi-chip devices, use <device_name>-magn to distinguish which
> + * capability is being used
>   */
>  static const struct of_device_id st_magn_of_match[] = {
>  	{
> --
> 2.11.0
> 

  reply	other threads:[~2018-10-28 18:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26  2:38 [PATCH v2 1/4] iio: magnetometer: add clarifying comment Martin Kelly
2018-10-26  2:38 ` [PATCH v2 2/4] iio:magnetometer: st_magn: add LSM9DS1 support Martin Kelly
2018-10-28 18:50   ` Jonathan Cameron
2018-10-26  2:38 ` [PATCH v2 3/4] iio:magnetometer: st_magn: add BDU settings Martin Kelly
2018-10-28 18:51   ` Jonathan Cameron
2018-10-26  2:38 ` [PATCH v2 4/4] dt-bindings: iio: magn: add LSM9DS1 bindings Martin Kelly
2018-10-28 18:53   ` Jonathan Cameron
2018-10-30 21:44     ` Rob Herring
2018-11-03 10:30       ` Jonathan Cameron
2018-10-26 18:24 ` [PATCH v2 1/4] iio: magnetometer: add clarifying comment Denis CIOCCA
2018-10-28 18:45   ` Jonathan Cameron [this message]
2018-10-28 18:48 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181028184505.5c6cb5fe@archlinux \
    --to=jic23@kernel.org \
    --cc=denis.ciocca@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=lorenzo.bianconi83@gmail.com \
    --cc=martin@martingkelly.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).