From mboxrd@z Thu Jan  1 00:00:00 1970
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH v2 7/7] arm64: dts: qcom: apq8016-sbc: Standardize LED
 labels
Date: Mon, 29 Oct 2018 15:02:10 +0530
Message-ID: <20181029093210.GA6110@Mani-XPS-13-9360>
References: <20181029090006.4353-1-manivannan.sadhasivam@linaro.org>
 <20181029090006.4353-8-manivannan.sadhasivam@linaro.org>
 <CAHLCerM91ukzAJZHaxXxwoHU-6mVUV+X9_y_Rs0zmybNnRJCfA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <CAHLCerM91ukzAJZHaxXxwoHU-6mVUV+X9_y_Rs0zmybNnRJCfA@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: Rob Herring <robh@kernel.org>, Heiko Stuebner <heiko@sntech.de>, ezequiel@collabora.com, Wei Xu <xuwei5@hisilicon.com>, Michal Simek <michal.simek@xilinx.com>, pavel@ucw.cz, Andy Gross <andy.gross@linaro.org>, linux-leds@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, lakml <linux-arm-kernel@lists.infradead.org>, LKML <linux-kernel@vger.kernel.org>, linux-rockchip@lists.infradead.org, linux-arm-msm <linux-arm-msm@vger.kernel.org>, "open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>, Daniel Thompson <daniel.thompson@linaro.org>, Linus Walleij <linus.walleij@linaro.org>, koen.kooi@linaro.org, nicolas.dechesne@linaro.org
List-Id: devicetree@vger.kernel.org

On Mon, Oct 29, 2018 at 02:47:11PM +0530, Amit Kucheria wrote:
> On Mon, Oct 29, 2018 at 2:31 PM Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org> wrote:
> >
> > For all 96Boards, the following standard is used for onboard LEDs.
> >
> > green:user1  default-trigger: heartbeat
> > green:user2  default-trigger: mmc0/disk-activity(onboard-storage)
> > green:user3  default-trigger: mmc1 (SD-card)
> > green:user4  default-trigger: none, panic-indicator
> > yellow:wlan  default-trigger: phy0tx
> > blue:bt      default-trigger: hci0-power
> >
> > So lets adopt the same for APQ8016 SBC (Dragonboard410c), which is
> > one of the 96Boards CE platform.
> 
> You are missing a signed-off here :-)
>

ahh, my bad. Will fix it in next revision.

Thanks,
Mani

> Acked-by: Amit Kucheria <amit.kucheria@linaro.org>
> 
> > ---
> >  arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > index 46feedf7c989..35f95154316b 100644
> > --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > @@ -300,28 +300,28 @@
> >                         compatible = "gpio-leds";
> >
> >                         led@1 {
> > -                               label = "apq8016-sbc:green:user1";
> > +                               label = "green:user1";
> >                                 gpios = <&msmgpio 21 GPIO_ACTIVE_HIGH>;
> >                                 linux,default-trigger = "heartbeat";
> >                                 default-state = "off";
> >                         };
> >
> >                         led@2 {
> > -                               label = "apq8016-sbc:green:user2";
> > +                               label = "green:user2";
> >                                 gpios = <&msmgpio 120 GPIO_ACTIVE_HIGH>;
> >                                 linux,default-trigger = "mmc0";
> >                                 default-state = "off";
> >                         };
> >
> >                         led@3 {
> > -                               label = "apq8016-sbc:green:user3";
> > +                               label = "green:user3";
> >                                 gpios = <&pm8916_gpios 1 GPIO_ACTIVE_HIGH>;
> >                                 linux,default-trigger = "mmc1";
> >                                 default-state = "off";
> >                         };
> >
> >                         led@4 {
> > -                               label = "apq8016-sbc:green:user4";
> > +                               label = "green:user4";
> >                                 gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
> >                                 linux,default-trigger = "none";
> >                                 panic-indicator;
> > @@ -329,14 +329,14 @@
> >                         };
> >
> >                         led@5 {
> > -                               label = "apq8016-sbc:yellow:wlan";
> > +                               label = "yellow:wlan";
> >                                 gpios = <&pm8916_mpps 2 GPIO_ACTIVE_HIGH>;
> >                                 linux,default-trigger = "phy0tx";
> >                                 default-state = "off";
> >                         };
> >
> >                         led@6 {
> > -                               label = "apq8016-sbc:blue:bt";
> > +                               label = "blue:bt";
> >                                 gpios = <&pm8916_mpps 3 GPIO_ACTIVE_HIGH>;
> >                                 linux,default-trigger = "bluetooth-power";
> >                                 default-state = "off";
> > --
> > 2.17.1
> >