From: Andrew Lunn <andrew@lunn.ch>
To: biao huang <biao.huang@mediatek.com>
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>,
davem@davemloft.net, robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, nelson.chang@mediatek.com,
netdev@vger.kernel.org, sean.wang@mediatek.com,
liguo.zhang@mediatek.com, linux-kernel@vger.kernel.org,
matthias.bgg@gmail.com, joabreu@synopsys.com,
linux-mediatek@lists.infradead.org, honghui.zhang@mediatek.com,
yt.shen@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712
Date: Tue, 30 Oct 2018 12:56:38 +0100 [thread overview]
Message-ID: <20181030115638.GB27873@lunn.ch> (raw)
In-Reply-To: <1540883812.26982.15.camel@mhfsdcap03>
> > > + plat_dat->interface = priv_plat->phy_mode;
> > > + /* clk_csr_i = 250-300MHz & MDC = clk_csr_i/124 */
> > > + plat_dat->clk_csr = 5;
> > > + plat_dat->has_gmac4 = 1;
> > > + plat_dat->has_gmac = 0;
> > > + plat_dat->pmt = 0;
> > > + plat_dat->maxmtu = 1500;
> >
> > ETH_DATA_LEN ?
> how about getting maxmtu from device tree rather than assignment here?
Does it vary between devices? I expect it is a constant, determined by
the DMA hardware design. So no need to make it configurabale.
Andrew
next prev parent reply other threads:[~2018-10-30 11:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 3:04 [v2, PATCH 0/2] add Ethernet driver support for mt2712 Biao Huang
2018-10-29 3:04 ` [PATCH 1/2] net:stmmac: dwmac-mediatek: add " Biao Huang
2018-10-29 10:08 ` Corentin Labbe
2018-10-30 7:16 ` biao huang
2018-10-30 11:56 ` Andrew Lunn [this message]
2018-10-29 12:27 ` Andrew Lunn
2018-10-30 7:11 ` biao huang
2018-10-29 3:04 ` [PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC Biao Huang
2018-11-12 16:22 ` Rob Herring
2018-11-16 6:58 ` biao huang
2018-10-29 3:32 ` [v2, PATCH 0/2] add Ethernet driver support for mt2712 biao huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030115638.GB27873@lunn.ch \
--to=andrew@lunn.ch \
--cc=biao.huang@mediatek.com \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=honghui.zhang@mediatek.com \
--cc=joabreu@synopsys.com \
--cc=liguo.zhang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=nelson.chang@mediatek.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=yt.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).