devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Martin Kelly <martin@martingkelly.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
	Denis Ciocca <denis.ciocca@st.com>
Subject: Re: [PATCH v2 4/4] dt-bindings: iio: magn: add LSM9DS1 bindings
Date: Tue, 30 Oct 2018 16:44:41 -0500	[thread overview]
Message-ID: <20181030214441.GA25441@bogus> (raw)
In-Reply-To: <20181028185308.20edd4f3@archlinux>

On Sun, Oct 28, 2018 at 06:53:08PM +0000, Jonathan Cameron wrote:
> On Thu, 25 Oct 2018 19:38:12 -0700
> Martin Kelly <martin@martingkelly.com> wrote:
> 
> > From: Martin Kelly <martin@martingkelly.com>
> > 
> > Add DT binding documentation for the LSM9DS1 magnetometer driver.

Bindings are for h/w, not drivers.

> > 
> > Signed-off-by: Martin Kelly <martin@martingkelly.com>
> Given here isn't really an alternative way of doing this (or we
> haven't come up with one yet) in the sensors that are basically multiple
> chips in one package, I'll hope that Rob is happy with the new name
> and apply it.   As I'm only pushing out for build tests today I can
> revert or add his Reviewed-by as needed.

Given only the supplies seem to be shared and those can be handled 
correctly with ref counting, separate devices is fine. We do the same 
thing for BT/WiFi combo chips with separate host interfaces.

Reviewed-by: Rob Herring <robh@kernel.org>

Rob

  reply	other threads:[~2018-10-30 21:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26  2:38 [PATCH v2 1/4] iio: magnetometer: add clarifying comment Martin Kelly
2018-10-26  2:38 ` [PATCH v2 2/4] iio:magnetometer: st_magn: add LSM9DS1 support Martin Kelly
2018-10-28 18:50   ` Jonathan Cameron
2018-10-26  2:38 ` [PATCH v2 3/4] iio:magnetometer: st_magn: add BDU settings Martin Kelly
2018-10-28 18:51   ` Jonathan Cameron
2018-10-26  2:38 ` [PATCH v2 4/4] dt-bindings: iio: magn: add LSM9DS1 bindings Martin Kelly
2018-10-28 18:53   ` Jonathan Cameron
2018-10-30 21:44     ` Rob Herring [this message]
2018-11-03 10:30       ` Jonathan Cameron
2018-10-26 18:24 ` [PATCH v2 1/4] iio: magnetometer: add clarifying comment Denis CIOCCA
2018-10-28 18:45   ` Jonathan Cameron
2018-10-28 18:48 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181030214441.GA25441@bogus \
    --to=robh@kernel.org \
    --cc=denis.ciocca@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=lorenzo.bianconi83@gmail.com \
    --cc=martin@martingkelly.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).