From: Guo Ren <ren_guo@c-sky.com>
To: Rob Herring <robh@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
"open list:GENERIC INCLUDE/ASM HEADER FILES"
<linux-arch@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH V3 2/2] csky: use common dtb build rules
Date: Wed, 31 Oct 2018 10:43:38 +0800 [thread overview]
Message-ID: <20181031024336.GA10756@guoren-Inspiron-7460> (raw)
In-Reply-To: <CAL_JsqKE4Nzcn7CXJTCuPkSWWn3qONcU=3WMQLK6xWptJQUE_A@mail.gmail.com>
On Tue, Oct 30, 2018 at 02:22:48PM -0500, Rob Herring wrote:
> On Tue, Oct 30, 2018 at 2:10 PM Rob Herring <robh@kernel.org> wrote:
> >
> > On Tue, Oct 30, 2018 at 12:50 PM Guo Ren <ren_guo@c-sky.com> wrote:
> > >
> > > Remove the Kbuild rules in arch/csky and use common dtb build rules.
> > >
> > > This modification is based on:
> > >
> > > commit 37c8a5fafa3b ("kbuild: consolidate Devicetree dtb build rules")
> > >
> > > Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> > > Cc: Rob Herring <robh@kernel.org>
> > > Cc: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > > arch/csky/Makefile | 11 +----------
> > > arch/csky/boot/dts/Makefile | 3 ---
> > > 2 files changed, 1 insertion(+), 13 deletions(-)
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
>
> BTW, it's not very not clear what the change from v2 was. In the
> future, please include a change log in each patch. Also, Arnd acked
> v2, so you should add those when posting a new version unless there's
> major changes, but don't post new versions just to add the
> acks/reviewed-bys. It doesn't really matter in this case as you are
> the maintainer and have to collect them, but generally the maintainers
> only collect acks on the version they apply and don't go looking at
> prior versions.
I sent "PATCH V2" too fast and there is no need for "PATCH V3" and I will
pay attention next time. Thanks for reminding.
Best Regards
Guo Ren
next prev parent reply other threads:[~2018-10-31 2:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 17:50 [PATCH V3 1/2] csky: remove builtin-dtb Kbuild Guo Ren
2018-10-30 17:50 ` [PATCH V3 2/2] csky: use common dtb build rules Guo Ren
2018-10-30 19:10 ` Rob Herring
2018-10-30 19:22 ` Rob Herring
2018-10-31 2:43 ` Guo Ren [this message]
2018-10-30 19:10 ` [PATCH V3 1/2] csky: remove builtin-dtb Kbuild Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031024336.GA10756@guoren-Inspiron-7460 \
--to=ren_guo@c-sky.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox