From: Shawn Guo <shawnguo@kernel.org>
To: Frieder Schrempf <frieder.schrempf@kontron.de>, peter.chen@nxp.com
Cc: devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx: Add dummy PHYs for HSIC-only USB controllers
Date: Wed, 31 Oct 2018 15:31:13 +0800 [thread overview]
Message-ID: <20181031073112.GL10386@tiger> (raw)
In-Reply-To: <1539848729-27646-1-git-send-email-frieder.schrempf@kontron.de>
On Thu, Oct 18, 2018 at 09:45:04AM +0200, Frieder Schrempf wrote:
> Some SOCs in the i.MX6 family have a USB host controller that is
> only capable of the HSIC interface and has no on-board PHY.
>
> To be able to use these controllers, we need to add "usb-nop-xceiv"
> dummy PHYs.
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
@Peter, looks good to you?
Shawn
> ---
> arch/arm/boot/dts/imx6qdl.dtsi | 14 ++++++++++++++
> arch/arm/boot/dts/imx6sl.dtsi | 7 +++++++
> arch/arm/boot/dts/imx6sx.dtsi | 6 ++++++
> 3 files changed, 27 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 61d2d26..d3404d1 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -139,6 +139,16 @@
> interrupts = <0 94 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + usbphynop1: usbphynop1 {
> + compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> + };
> +
> + usbphynop2: usbphynop2 {
> + compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> + };
> +
> soc {
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -981,6 +991,8 @@
> reg = <0x02184400 0x200>;
> interrupts = <0 41 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks IMX6QDL_CLK_USBOH3>;
> + fsl,usbphy = <&usbphynop1>;
> + phy_type = "hsic";
> fsl,usbmisc = <&usbmisc 2>;
> dr_mode = "host";
> ahb-burst-config = <0x0>;
> @@ -994,6 +1006,8 @@
> reg = <0x02184600 0x200>;
> interrupts = <0 42 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks IMX6QDL_CLK_USBOH3>;
> + fsl,usbphy = <&usbphynop2>;
> + phy_type = "hsic";
> fsl,usbmisc = <&usbmisc 3>;
> dr_mode = "host";
> ahb-burst-config = <0x0>;
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 7a4f5da..81edcdc 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -110,6 +110,11 @@
> interrupts = <0 94 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + usbphynop1: usbphynop1 {
> + compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> + };
> +
> soc {
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -815,6 +820,8 @@
> reg = <0x02184400 0x200>;
> interrupts = <0 40 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks IMX6SL_CLK_USBOH3>;
> + fsl,usbphy = <&usbphynop1>;
> + phy_type = "hsic";
> fsl,usbmisc = <&usbmisc 2>;
> dr_mode = "host";
> ahb-burst-config = <0x0>;
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 844caa3..07ed417 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -159,6 +159,11 @@
> interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + usbphynop1: usbphynop1 {
> + compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> + };
> +
> soc {
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -877,6 +882,7 @@
> reg = <0x02184400 0x200>;
> interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks IMX6SX_CLK_USBOH3>;
> + fsl,usbphy = <&usbphynop1>;
> fsl,usbmisc = <&usbmisc 2>;
> phy_type = "hsic";
> fsl,anatop = <&anatop>;
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-10-31 7:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 7:45 [PATCH] ARM: dts: imx: Add dummy PHYs for HSIC-only USB controllers Frieder Schrempf
2018-10-25 13:08 ` Fabio Estevam
2018-10-31 7:31 ` Shawn Guo [this message]
2018-11-22 6:48 ` PETER CHEN
2018-11-22 7:41 ` Schrempf Frieder
2018-11-26 14:02 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031073112.GL10386@tiger \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=frieder.schrempf@kontron.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).