devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Shyam Saini <shyam.saini@amarulasolutions.com>
Cc: devicetree@vger.kernel.org, s.hauer@pengutronix.de,
	l.stach@pengutronix.de, Jagan Teki <jagan@amarulasolutions.com>,
	kernel@pengutronix.de, u.kleine-koenig@pengutronix.de,
	fabio.estevam@nxp.com,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com
Subject: Re: [PATCH V2] ARM: dts: imx6qdl-icore: Add missing stdout-path property
Date: Wed, 31 Oct 2018 15:56:31 +0800	[thread overview]
Message-ID: <20181031075630.GN10386@tiger> (raw)
In-Reply-To: <CA+drQ_OZHPSXoECX4z7oWEwNV11EUn=DviNa6nmDpWKBs2o8+Q@mail.gmail.com>

On Tue, Oct 23, 2018 at 10:51:59AM +0530, Shyam Saini wrote:
> On Fri, Oct 19, 2018 at 12:15 AM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > On Thu, Oct 18, 2018 at 08:33:05PM +0530, Shyam Saini wrote:
> > > This would help us to get early boot logs by passing "earlycon" to
> > > kernel bootargs.
> > >
> > > Further, by adding this we don't have to depend on complex earlyprintk
> > > configs for early boot logs.
> > >
> > > Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
> > > Reviewed-by: Fabio Estevam <festevam@gmail.com>
> >
> > minor nit: your S-o-b line should be the last thing you write. So it's
> >
> >         Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
> >         Reviewed-by: Fabio Estevam <festevam@gmail.com>
> >         Signed-off-by: John Maintainer <john@example.org>
> >
> > if John added the Reviewed-by tag and
> >
> >         Reviewed-by: Fabio Estevam <festevam@gmail.com>
> >         Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
> >         Signed-off-by: John Maintainer <john@example.org>
> >
> > if it was you.
> 
> Thanks a lot Uwe for your suggestion. I'll take care of this thing next time.
> @Shawn would you please make the minor change as suggested by Uwe.

Applied with the suggested change, thanks.

      reply	other threads:[~2018-10-31  7:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18 15:03 [PATCH V2] ARM: dts: imx6qdl-icore: Add missing stdout-path property Shyam Saini
2018-10-18 18:45 ` Uwe Kleine-König
2018-10-23  5:21   ` Shyam Saini
2018-10-31  7:56     ` Shawn Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181031075630.GN10386@tiger \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=jagan@amarulasolutions.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=michael@amarulasolutions.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shyam.saini@amarulasolutions.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).