devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2] ARM: dts: imx6qdl-icore: Add missing stdout-path property
@ 2018-10-18 15:03 Shyam Saini
  2018-10-18 18:45 ` Uwe Kleine-König
  0 siblings, 1 reply; 4+ messages in thread
From: Shyam Saini @ 2018-10-18 15:03 UTC (permalink / raw)
  To: shawnguo
  Cc: devicetree, s.hauer, linux-imx, Shyam Saini, jagan, kernel,
	fabio.estevam, michael, linux-arm-kernel, l.stach

This would help us to get early boot logs by passing "earlycon" to
kernel bootargs.

Further, by adding this we don't have to depend on complex earlyprintk
configs for early boot logs.

Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/boot/dts/imx6qdl-icore.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi
index 9ce993776160..f5b8ea6f7ee9 100644
--- a/arch/arm/boot/dts/imx6qdl-icore.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi
@@ -49,6 +49,10 @@
 		reg = <0x10000000 0x80000000>;
 	};
 
+	chosen {
+		stdout-path = &uart4;
+	};
+
 	backlight_lvds: backlight-lvds {
 		compatible = "pwm-backlight";
 		pwms = <&pwm3 0 100000>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH V2] ARM: dts: imx6qdl-icore: Add missing stdout-path property
  2018-10-18 15:03 [PATCH V2] ARM: dts: imx6qdl-icore: Add missing stdout-path property Shyam Saini
@ 2018-10-18 18:45 ` Uwe Kleine-König
  2018-10-23  5:21   ` Shyam Saini
  0 siblings, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2018-10-18 18:45 UTC (permalink / raw)
  To: Shyam Saini
  Cc: devicetree, s.hauer, linux-imx, kernel, l.stach, fabio.estevam,
	michael, shawnguo, linux-arm-kernel, jagan

On Thu, Oct 18, 2018 at 08:33:05PM +0530, Shyam Saini wrote:
> This would help us to get early boot logs by passing "earlycon" to
> kernel bootargs.
> 
> Further, by adding this we don't have to depend on complex earlyprintk
> configs for early boot logs.
> 
> Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

minor nit: your S-o-b line should be the last thing you write. So it's

	Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
	Reviewed-by: Fabio Estevam <festevam@gmail.com>
	Signed-off-by: John Maintainer <john@example.org>

if John added the Reviewed-by tag and 

	Reviewed-by: Fabio Estevam <festevam@gmail.com>
	Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
	Signed-off-by: John Maintainer <john@example.org>

if it was you.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V2] ARM: dts: imx6qdl-icore: Add missing stdout-path property
  2018-10-18 18:45 ` Uwe Kleine-König
@ 2018-10-23  5:21   ` Shyam Saini
  2018-10-31  7:56     ` Shawn Guo
  0 siblings, 1 reply; 4+ messages in thread
From: Shyam Saini @ 2018-10-23  5:21 UTC (permalink / raw)
  To: u.kleine-koenig
  Cc: devicetree, s.hauer, linux-imx, kernel, l.stach, fabio.estevam,
	Michael Nazzareno Trimarchi, shawnguo, linux-arm-kernel,
	Jagan Teki

On Fri, Oct 19, 2018 at 12:15 AM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> On Thu, Oct 18, 2018 at 08:33:05PM +0530, Shyam Saini wrote:
> > This would help us to get early boot logs by passing "earlycon" to
> > kernel bootargs.
> >
> > Further, by adding this we don't have to depend on complex earlyprintk
> > configs for early boot logs.
> >
> > Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
> > Reviewed-by: Fabio Estevam <festevam@gmail.com>
>
> minor nit: your S-o-b line should be the last thing you write. So it's
>
>         Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
>         Reviewed-by: Fabio Estevam <festevam@gmail.com>
>         Signed-off-by: John Maintainer <john@example.org>
>
> if John added the Reviewed-by tag and
>
>         Reviewed-by: Fabio Estevam <festevam@gmail.com>
>         Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
>         Signed-off-by: John Maintainer <john@example.org>
>
> if it was you.

Thanks a lot Uwe for your suggestion. I'll take care of this thing next time.
@Shawn would you please make the minor change as suggested by Uwe.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V2] ARM: dts: imx6qdl-icore: Add missing stdout-path property
  2018-10-23  5:21   ` Shyam Saini
@ 2018-10-31  7:56     ` Shawn Guo
  0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2018-10-31  7:56 UTC (permalink / raw)
  To: Shyam Saini
  Cc: devicetree, s.hauer, l.stach, Jagan Teki, kernel, u.kleine-koenig,
	fabio.estevam, Michael Nazzareno Trimarchi, linux-arm-kernel,
	linux-imx

On Tue, Oct 23, 2018 at 10:51:59AM +0530, Shyam Saini wrote:
> On Fri, Oct 19, 2018 at 12:15 AM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > On Thu, Oct 18, 2018 at 08:33:05PM +0530, Shyam Saini wrote:
> > > This would help us to get early boot logs by passing "earlycon" to
> > > kernel bootargs.
> > >
> > > Further, by adding this we don't have to depend on complex earlyprintk
> > > configs for early boot logs.
> > >
> > > Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
> > > Reviewed-by: Fabio Estevam <festevam@gmail.com>
> >
> > minor nit: your S-o-b line should be the last thing you write. So it's
> >
> >         Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
> >         Reviewed-by: Fabio Estevam <festevam@gmail.com>
> >         Signed-off-by: John Maintainer <john@example.org>
> >
> > if John added the Reviewed-by tag and
> >
> >         Reviewed-by: Fabio Estevam <festevam@gmail.com>
> >         Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
> >         Signed-off-by: John Maintainer <john@example.org>
> >
> > if it was you.
> 
> Thanks a lot Uwe for your suggestion. I'll take care of this thing next time.
> @Shawn would you please make the minor change as suggested by Uwe.

Applied with the suggested change, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-10-31  7:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-18 15:03 [PATCH V2] ARM: dts: imx6qdl-icore: Add missing stdout-path property Shyam Saini
2018-10-18 18:45 ` Uwe Kleine-König
2018-10-23  5:21   ` Shyam Saini
2018-10-31  7:56     ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).