devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Badhri Jagan Sridharan <badhri@google.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Andrzej Hajda <a.hajda@samsung.com>, Li Jun <jun.li@nxp.com>,
	linux@roeck-us.net, jackp@codeaurora.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: connector: Add self-powered property
Date: Fri, 2 Nov 2018 15:27:58 +0200	[thread overview]
Message-ID: <20181102132758.GA6543@kuha.fi.intel.com> (raw)
In-Reply-To: <20181001194501.58338-1-badhri@google.com>

On Mon, Oct 01, 2018 at 12:44:59PM -0700, Badhri Jagan Sridharan wrote:
> >From USB_PD_R3_0
> 7.1.5 Response to Hard Resets
> Device operation during and after a Hard Reset is defined as follows:
> Self-powered devices Should Not disconnect from USB during a Hard Reset
> (see Section 9.1.2).
> Bus powered devices will disconnect from USB during a Hard Reset due to the
> loss of their power source.
> 
> Therefore it is necessary to know whether the port belongs to
> a device which is self powered or bus powered. This change
> adds "self-powered" flag to the connector class which present indicates
> that the port belongs to a device that is self powered. Else it is
> bus powered usb device.
> 
> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>

Rob, I can see you acked one of the patches modifying tcpm.c in this
series, but did you mean to put the tag to this patch instead?

FWIW:

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> -------
> Changes is v3:
> - Rebase on top of usb-next
> - no change w.r.t to this patch. Same as previous versions.
> 
> No v2 version as the patch was introduced there.
> 
> ---
>  Documentation/devicetree/bindings/connector/usb-connector.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt
> index d90e17e2428b..a9a2f2fc44f2 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.txt
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
> @@ -14,6 +14,8 @@ Optional properties:
>  - label: symbolic name for the connector,
>  - type: size of the connector, should be specified in case of USB-A, USB-B
>    non-fullsize connectors: "mini", "micro".
> +- self-powered: Set this property if the usb device that has its own power
> +  source.
>  
>  Optional properties for usb-c-connector:
>  - power-role: should be one of "source", "sink" or "dual"(DRP) if typec
> -- 
> 2.19.0.605.g01d371f741-goog

thanks,

-- 
heikki

  parent reply	other threads:[~2018-11-02 13:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-01 19:44 [PATCH v3 1/3] dt-bindings: connector: Add self-powered property Badhri Jagan Sridharan
2018-10-01 19:45 ` [PATCH v3 2/3] usb: typec: tcpm: Do not disconnect link for self powered devices Badhri Jagan Sridharan
2018-11-02 13:28   ` Heikki Krogerus
2018-10-01 19:45 ` [PATCH v3 3/3] usb: typec: tcpm: charge current handling for sink during hard reset Badhri Jagan Sridharan
2018-10-12 14:48   ` Rob Herring
2018-11-02 13:28   ` Heikki Krogerus
2018-11-06  0:15     ` Badhri Jagan Sridharan
2018-11-06  9:10       ` Heikki Krogerus
2018-11-02 13:27 ` Heikki Krogerus [this message]
2018-11-02 13:44   ` [PATCH v3 1/3] dt-bindings: connector: Add self-powered property Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181102132758.GA6543@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=a.hajda@samsung.com \
    --cc=badhri@google.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jackp@codeaurora.org \
    --cc=jun.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).