From: Pavel Machek <pavel@ucw.cz>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 1/2] DT: marvell,mmp2: fix TWSI2
Date: Sat, 3 Nov 2018 20:05:24 +0100 [thread overview]
Message-ID: <20181103190524.GC31179@amd> (raw)
In-Reply-To: <20180917113947.12626-2-lkundrak@v3.sk>
[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]
On Mon 2018-09-17 13:39:46, Lubomir Rintel wrote:
> Marvell keeps their MMP2 datasheet secret, but there are good clues
> that TWSI2 is not on 0xd4025000 on that platform, not does it use
> IRQ 58. In fact, the IRQ 58 on MMP2 seems to be a signal processor:
>
> arch/arm/mach-mmp/irqs.h:#define IRQ_MMP2_MSP 58
>
> I'm taking a somewhat educated guess that is probably a copy & paste
> error from PXA168 or PXA910 and that the real controller in fact hides
> at address 0xd4031000 and uses an interrupt line multiplexed via IRQ 17.
>
> I'm also copying some properties from TWSI1 that were missing or
> incorrect.
>
> Tested on a OLPC XO 1.75 machine, where the RTC is on TWSI2.
>
> Cc: Eric Miao <eric.y.miao@gmail.com>
> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Acked-by: Pavel Machek <pavel@ucw.cz>
> status = "disabled";
> };
>
> - twsi2: i2c@d4025000 {
> + twsi2: i2c@d4031000 {
> compatible = "mrvl,mmp-twsi";
> - reg = <0xd4025000 0x1000>;
> - interrupts = <58>;
> + reg = <0xd4031000 0x1000>;
> + interrupt-parent = <&intcmux17>;
> + interrupts = <0>;
> clocks = <&soc_clocks MMP2_CLK_TWSI1>;
> resets = <&soc_clocks MMP2_CLK_TWSI1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> status = "disabled";
> };
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-11-03 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 11:39 [PATCH 0/2] Fix TWSI on MMC2 Lubomir Rintel
2018-09-17 11:39 ` [PATCH 1/2] DT: marvell,mmp2: fix TWSI2 Lubomir Rintel
2018-11-03 19:05 ` Pavel Machek [this message]
2018-09-17 11:39 ` [PATCH 2/2] DT: marvell,mmp2: add more TWSI controllers Lubomir Rintel
2018-11-03 19:05 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181103190524.GC31179@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).