From: Pavel Machek <pavel@ucw.cz>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 2/2] DT: marvell,mmp2: add more TWSI controllers
Date: Sat, 3 Nov 2018 20:05:47 +0100 [thread overview]
Message-ID: <20181103190547.GD31179@amd> (raw)
In-Reply-To: <20180917113947.12626-3-lkundrak@v3.sk>
[-- Attachment #1: Type: text/plain, Size: 2689 bytes --]
On Mon 2018-09-17 13:39:47, Lubomir Rintel wrote:
> I've gotten the base addresses, clocks and interrupts from an rusty and old
> out-of-tree driver. I haven't actually checked against the datasheet, since
> that one is reserved for the Marvell inner circle.
>
> Tested with an accelerometer on TWSI6 on an OLPC XO 1.75 machine.
>
> Cc: Eric Miao <eric.y.miao@gmail.com>
> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> arch/arm/boot/dts/mmp2.dtsi | 49 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 49 insertions(+)
>
> diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi
> index 47e5b63339d1..2bd4e94501ce 100644
> --- a/arch/arm/boot/dts/mmp2.dtsi
> +++ b/arch/arm/boot/dts/mmp2.dtsi
> @@ -232,6 +232,55 @@
> status = "disabled";
> };
>
> + twsi3: i2c@d4032000 {
> + compatible = "mrvl,mmp-twsi";
> + reg = <0xd4032000 0x1000>;
> + interrupt-parent = <&intcmux17>;
> + interrupts = <1>;
> + clocks = <&soc_clocks MMP2_CLK_TWSI2>;
> + resets = <&soc_clocks MMP2_CLK_TWSI2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + twsi4: i2c@d4033000 {
> + compatible = "mrvl,mmp-twsi";
> + reg = <0xd4033000 0x1000>;
> + interrupt-parent = <&intcmux17>;
> + interrupts = <2>;
> + clocks = <&soc_clocks MMP2_CLK_TWSI3>;
> + resets = <&soc_clocks MMP2_CLK_TWSI3>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> +
> + twsi5: i2c@d4033800 {
> + compatible = "mrvl,mmp-twsi";
> + reg = <0xd4033800 0x1000>;
> + interrupt-parent = <&intcmux17>;
> + interrupts = <3>;
> + clocks = <&soc_clocks MMP2_CLK_TWSI4>;
> + resets = <&soc_clocks MMP2_CLK_TWSI4>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + twsi6: i2c@d4034000 {
> + compatible = "mrvl,mmp-twsi";
> + reg = <0xd4034000 0x1000>;
> + interrupt-parent = <&intcmux17>;
> + interrupts = <4>;
> + clocks = <&soc_clocks MMP2_CLK_TWSI5>;
> + resets = <&soc_clocks MMP2_CLK_TWSI5>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> rtc: rtc@d4010000 {
> compatible = "mrvl,mmp-rtc";
> reg = <0xd4010000 0x1000>;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2018-11-03 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 11:39 [PATCH 0/2] Fix TWSI on MMC2 Lubomir Rintel
2018-09-17 11:39 ` [PATCH 1/2] DT: marvell,mmp2: fix TWSI2 Lubomir Rintel
2018-11-03 19:05 ` Pavel Machek
2018-09-17 11:39 ` [PATCH 2/2] DT: marvell,mmp2: add more TWSI controllers Lubomir Rintel
2018-11-03 19:05 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181103190547.GD31179@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).