From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v2 1/4] dt-bindings: mrvl,mmp-timer: add clock Date: Sat, 3 Nov 2018 20:14:50 +0100 Message-ID: <20181103191449.GG31179@amd> References: <20180918205455.25464-1-lkundrak@v3.sk> <20180918205455.25464-2-lkundrak@v3.sk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RDS4xtyBfx+7DiaI" Return-path: Content-Disposition: inline In-Reply-To: <20180918205455.25464-2-lkundrak@v3.sk> Sender: linux-kernel-owner@vger.kernel.org To: Lubomir Rintel Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Daniel Lezcano , Thomas Gleixner , Rob Herring , Mark Rutland , Eric Miao , Haojian Zhuang , Russell King List-Id: devicetree@vger.kernel.org --RDS4xtyBfx+7DiaI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2018-09-18 22:54:52, Lubomir Rintel wrote: > The timer needs the timer clock to be enabled, otherwise it stops > ticking. >=20 > Signed-off-by: Lubomir Rintel > Reviewed-by: Rob Herring Acked-by: Pavel Machek > --- > Changes since v1: > - Made the clock optional, to keep compatibility with DTs without it >=20 > Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt b= /Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt > index 9a6e251462e7..b8f02c663521 100644 > --- a/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt > +++ b/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt > @@ -5,9 +5,13 @@ Required properties: > - reg : Address and length of the register set of timer controller. > - interrupts : Should be the interrupt number. > =20 > +Optional properties: > +- clocks : Should contain a single entry describing the clock input. > + > Example: > timer0: timer@d4014000 { > compatible =3D "mrvl,mmp-timer"; > reg =3D <0xd4014000 0x100>; > interrupts =3D <13>; > + clocks =3D <&coreclk 2>; > }; --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --RDS4xtyBfx+7DiaI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlvd86kACgkQMOfwapXb+vLeSACfS5SqUwjMRNdgqkk+HEPTq6zB zTIAoJRjcH1mr9mcHZDiBzsrmWoAvbO2 =CcrF -----END PGP SIGNATURE----- --RDS4xtyBfx+7DiaI--