* [PATCH v3 1/4] dt-bindings: adv748x: make data-lanes property mandatory for CSI-2 endpoints [not found] <20181102160009.17267-1-niklas.soderlund+renesas@ragnatech.se> @ 2018-11-02 16:00 ` Niklas Söderlund 2018-11-05 8:41 ` jacopo mondi 2018-11-05 10:43 ` Laurent Pinchart 0 siblings, 2 replies; 4+ messages in thread From: Niklas Söderlund @ 2018-11-02 16:00 UTC (permalink / raw) To: Kieran Bingham, Laurent Pinchart, Jacopo Mondi, linux-media Cc: linux-renesas-soc, Niklas Söderlund, Rob Herring, devicetree The CSI-2 transmitters can use a different number of lanes to transmit data. Make the data-lanes mandatory for the endpoints that describe the transmitters as no good default can be set to fallback on. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- * Changes since v2 - Update paragraph according to Laurents comments. --- Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt b/Documentation/devicetree/bindings/media/i2c/adv748x.txt index 5dddc95f9cc46084..bffbabc879efd86c 100644 --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt @@ -48,7 +48,9 @@ are numbered as follows. TXA source 10 TXB source 11 -The digital output port nodes must contain at least one endpoint. +The digital output port nodes, when present, shall contain at least one +endpoint. Each of those endpoints shall contain the data-lanes property as +described in video-interfaces.txt. Ports are optional if they are not connected to anything at the hardware level. -- 2.19.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: adv748x: make data-lanes property mandatory for CSI-2 endpoints 2018-11-02 16:00 ` [PATCH v3 1/4] dt-bindings: adv748x: make data-lanes property mandatory for CSI-2 endpoints Niklas Söderlund @ 2018-11-05 8:41 ` jacopo mondi 2018-11-05 20:39 ` Rob Herring 2018-11-05 10:43 ` Laurent Pinchart 1 sibling, 1 reply; 4+ messages in thread From: jacopo mondi @ 2018-11-05 8:41 UTC (permalink / raw) To: Niklas Söderlund Cc: Kieran Bingham, Laurent Pinchart, linux-media, linux-renesas-soc, Rob Herring, devicetree [-- Attachment #1: Type: text/plain, Size: 1837 bytes --] Hi Niklas, On Fri, Nov 02, 2018 at 05:00:06PM +0100, Niklas Söderlund wrote: > The CSI-2 transmitters can use a different number of lanes to transmit > data. Make the data-lanes mandatory for the endpoints that describe the > transmitters as no good default can be set to fallback on. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > --- > * Changes since v2 > - Update paragraph according to Laurents comments. > --- > Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > index 5dddc95f9cc46084..bffbabc879efd86c 100644 > --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > @@ -48,7 +48,9 @@ are numbered as follows. > TXA source 10 > TXB source 11 > > -The digital output port nodes must contain at least one endpoint. > +The digital output port nodes, when present, shall contain at least one > +endpoint. Each of those endpoints shall contain the data-lanes property as > +described in video-interfaces.txt. > > Ports are optional if they are not connected to anything at the hardware level. > Re-vamping my ignored comment on v2, I still think you should list here the accepted values for each TX as they're actually a property of the hw device itself. Required endpoint properties: - data-lanes: See "video-interfaces.txt" for description. The property is mandatory for CSI-2 output endpoints and the accepted value depends on which endpoint the property is applied to: - TXA: accepted values are <1>, <2>, <4> - TXB: accepted value is <1> > -- > 2.19.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: adv748x: make data-lanes property mandatory for CSI-2 endpoints 2018-11-05 8:41 ` jacopo mondi @ 2018-11-05 20:39 ` Rob Herring 0 siblings, 0 replies; 4+ messages in thread From: Rob Herring @ 2018-11-05 20:39 UTC (permalink / raw) To: jacopo mondi Cc: Niklas Söderlund, Kieran Bingham, Laurent Pinchart, linux-media, linux-renesas-soc, devicetree On Mon, Nov 05, 2018 at 09:41:06AM +0100, jacopo mondi wrote: > Hi Niklas, > > On Fri, Nov 02, 2018 at 05:00:06PM +0100, Niklas S�derlund wrote: > > The CSI-2 transmitters can use a different number of lanes to transmit > > data. Make the data-lanes mandatory for the endpoints that describe the > > transmitters as no good default can be set to fallback on. > > > > Signed-off-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se> > > > > --- > > * Changes since v2 > > - Update paragraph according to Laurents comments. > > --- > > Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > > index 5dddc95f9cc46084..bffbabc879efd86c 100644 > > --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > > +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > > @@ -48,7 +48,9 @@ are numbered as follows. > > TXA source 10 > > TXB source 11 > > > > -The digital output port nodes must contain at least one endpoint. > > +The digital output port nodes, when present, shall contain at least one > > +endpoint. Each of those endpoints shall contain the data-lanes property as > > +described in video-interfaces.txt. > > > > Ports are optional if they are not connected to anything at the hardware level. > > > > Re-vamping my ignored comment on v2, I still think you should list here the > accepted values for each TX as they're actually a property of the hw > device itself. > > Required endpoint properties: > - data-lanes: See "video-interfaces.txt" for description. The property > is mandatory for CSI-2 output endpoints and the accepted value > depends on which endpoint the property is applied to: > - TXA: accepted values are <1>, <2>, <4> > - TXB: accepted value is <1> +1 Rob ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: adv748x: make data-lanes property mandatory for CSI-2 endpoints 2018-11-02 16:00 ` [PATCH v3 1/4] dt-bindings: adv748x: make data-lanes property mandatory for CSI-2 endpoints Niklas Söderlund 2018-11-05 8:41 ` jacopo mondi @ 2018-11-05 10:43 ` Laurent Pinchart 1 sibling, 0 replies; 4+ messages in thread From: Laurent Pinchart @ 2018-11-05 10:43 UTC (permalink / raw) To: Niklas Söderlund Cc: Kieran Bingham, Jacopo Mondi, linux-media, linux-renesas-soc, Rob Herring, devicetree Hi Niklas, Thank you for the patch. On Friday, 2 November 2018 18:00:06 EET Niklas Söderlund wrote: > The CSI-2 transmitters can use a different number of lanes to transmit > data. Make the data-lanes mandatory for the endpoints that describe the > transmitters as no good default can be set to fallback on. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > * Changes since v2 > - Update paragraph according to Laurents comments. > --- > Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > b/Documentation/devicetree/bindings/media/i2c/adv748x.txt index > 5dddc95f9cc46084..bffbabc879efd86c 100644 > --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > @@ -48,7 +48,9 @@ are numbered as follows. > TXA source 10 > TXB source 11 > > -The digital output port nodes must contain at least one endpoint. > +The digital output port nodes, when present, shall contain at least one > +endpoint. Each of those endpoints shall contain the data-lanes property as > +described in video-interfaces.txt. > > Ports are optional if they are not connected to anything at the hardware > level. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-05 20:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20181102160009.17267-1-niklas.soderlund+renesas@ragnatech.se>
2018-11-02 16:00 ` [PATCH v3 1/4] dt-bindings: adv748x: make data-lanes property mandatory for CSI-2 endpoints Niklas Söderlund
2018-11-05 8:41 ` jacopo mondi
2018-11-05 20:39 ` Rob Herring
2018-11-05 10:43 ` Laurent Pinchart
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).