From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Jonathan McDowell <noodles@earth.li>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>
Subject: Re: [PATCHv2] ARM: dts: sun8i-h3: Add dts for the Mapleboard MP130
Date: Mon, 5 Nov 2018 10:05:47 +0100 [thread overview]
Message-ID: <20181105090547.yuiblwnnpffykilg@flea> (raw)
In-Reply-To: <20181030221430.wu5cxicyf4ub2boa@earth.li>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Tue, Oct 30, 2018 at 10:14:30PM +0000, Jonathan McDowell wrote:
> + r_gpio_keys {
> + compatible = "gpio-keys";
> + pinctrl-names = "default";
> +
> + power {
> + label = "mp130:power";
That was my mistake, but it was correct in your first version.
> +&pio {
> + leds_pio: led_pins {
> + pins = "PA15";
> + function = "gpio_out";
> + };
> +};
> +
> +&r_pio {
> + leds_r_pio: led_pins {
> + pins = "PL10";
> + function = "gpio_out";
> + };
> +
> + sw_r_pio: key_pins {
> + pins = "PL3", "PL4";
> + function = "gpio_in";
> + };
> +};
You don't need these nodes at all.
I've fixed both issues and applied your patch for 4.21
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2018-11-05 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 22:14 [PATCHv2] ARM: dts: sun8i-h3: Add dts for the Mapleboard MP130 Jonathan McDowell
2018-11-05 9:05 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105090547.yuiblwnnpffykilg@flea \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noodles@earth.li \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).