From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 02/10] drm/sun4i: sun6i_mipi_dsi: Support instruction loop selection Date: Mon, 5 Nov 2018 11:38:57 +0100 Message-ID: <20181105103857.lp7ayw3p6dbthehg@flea> References: <20181103100900.30313-1-jagan@amarulasolutions.com> <20181103100900.30313-3-jagan@amarulasolutions.com> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2mml74iousjnfa23" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20181103100900.30313-3-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Jagan Teki Cc: Maarten Lankhorst , Sean Paul , David Airlie , Rob Herring , Chen-Yu Tsai , Icenowy Zheng , Jernej Skrabec , Vasily Khoruzhick , Thierry Reding , Mark Rutland , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Michael Trimarchi , TL Lim , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --2mml74iousjnfa23 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Sat, Nov 03, 2018 at 03:38:52PM +0530, Jagan Teki wrote: > Instruction loop selection would require before writing > loop number registers, so enable idle, LP11 bits on > loop selection register. > > Reference code available in BSP > (in drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) > (dsi_dev[sel]->dsi_inst_loop_sel.dwval = 2<<(4*DSI_INST_ID_LP11) | > 3<<(4*DSI_INST_ID_DLY); > > Signed-off-by: Jagan Teki > --- > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > index da152c21ec62..077b57ec964c 100644 > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > @@ -397,6 +397,10 @@ static void sun6i_dsi_setup_inst_loop(struct sun6i_dsi *dsi, > struct mipi_dsi_device *device = dsi->device; > u16 delay; > > + regmap_write(dsi->regs, SUN6I_DSI_INST_LOOP_SEL_REG, > + DSI_INST_ID_HSC << (4 * DSI_INST_ID_LP11) | > + DSI_INST_ID_HSD << (4 * DSI_INST_ID_DLY)); > + Please put this with the other instructions settings below. hanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --2mml74iousjnfa23--