* [PATCH] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering
@ 2018-11-05 11:49 Jacopo Mondi
2018-11-05 12:03 ` Laurent Pinchart
2018-11-05 12:07 ` Geert Uytterhoeven
0 siblings, 2 replies; 6+ messages in thread
From: Jacopo Mondi @ 2018-11-05 11:49 UTC (permalink / raw)
To: horms, geert, laurent.pinchart
Cc: Jacopo Mondi, linux-renesas-soc, devicetree, Koji Matsuoka,
Takeshi Kihara
The VIN driver bindings dictates fixed numbering for VIN endpoints connected
to CSI-2 endpoints, even when a single endpoint exists.
Without proper endpoint numbering the VIN driver fails to probe.
Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2 device nodes")
Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
arch/arm64/boot/dts/renesas/r8a77990.dtsi | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
index 9509dc0..97f7e0c 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
@@ -747,7 +747,8 @@
port@1 {
reg = <1>;
- vin4csi40: endpoint {
+ vin4csi40: endpoint@2 {
+ reg = <2>;
remote-endpoint= <&csi40vin4>;
};
};
@@ -771,7 +772,8 @@
port@1 {
reg = <1>;
- vin5csi40: endpoint {
+ vin5csi40: endpoint@2 {
+ reg = <2>;
remote-endpoint= <&csi40vin5>;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering 2018-11-05 11:49 [PATCH] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering Jacopo Mondi @ 2018-11-05 12:03 ` Laurent Pinchart 2018-11-05 12:07 ` Geert Uytterhoeven 1 sibling, 0 replies; 6+ messages in thread From: Laurent Pinchart @ 2018-11-05 12:03 UTC (permalink / raw) To: Jacopo Mondi Cc: horms, geert, linux-renesas-soc, devicetree, Koji Matsuoka, Takeshi Kihara Hi Jacopo, Thank you for the patch. On Monday, 5 November 2018 13:49:21 EET Jacopo Mondi wrote: > The VIN driver bindings dictates fixed numbering for VIN endpoints connected > to CSI-2 endpoints, even when a single endpoint exists. > > Without proper endpoint numbering the VIN driver fails to probe. > > Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2 > device nodes") Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index 9509dc0..97f7e0c 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > @@ -747,7 +747,8 @@ > port@1 { > reg = <1>; > > - vin4csi40: endpoint { > + vin4csi40: endpoint@2 { > + reg = <2>; > remote-endpoint= <&csi40vin4>; > }; > }; > @@ -771,7 +772,8 @@ > port@1 { > reg = <1>; > > - vin5csi40: endpoint { > + vin5csi40: endpoint@2 { > + reg = <2>; > remote-endpoint= <&csi40vin5>; > }; > }; > -- > 2.7.4 -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering 2018-11-05 11:49 [PATCH] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering Jacopo Mondi 2018-11-05 12:03 ` Laurent Pinchart @ 2018-11-05 12:07 ` Geert Uytterhoeven 2018-11-05 12:46 ` jacopo mondi 1 sibling, 1 reply; 6+ messages in thread From: Geert Uytterhoeven @ 2018-11-05 12:07 UTC (permalink / raw) To: Jacopo Mondi Cc: Simon Horman, Laurent Pinchart, Linux-Renesas, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Koji Matsuoka, Takeshi Kihara Hi Jacopo, Thanks for your patch! On Mon, Nov 5, 2018 at 12:49 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > The VIN driver bindings dictates fixed numbering for VIN endpoints connected > to CSI-2 endpoints, even when a single endpoint exists. > > Without proper endpoint numbering the VIN driver fails to probe. > > Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2 device nodes") > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com> Was this patch authored by you or by Matsuoka-san? > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering 2018-11-05 12:07 ` Geert Uytterhoeven @ 2018-11-05 12:46 ` jacopo mondi 2018-11-05 12:57 ` Geert Uytterhoeven 0 siblings, 1 reply; 6+ messages in thread From: jacopo mondi @ 2018-11-05 12:46 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Jacopo Mondi, Simon Horman, Laurent Pinchart, Linux-Renesas, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Koji Matsuoka, Takeshi Kihara [-- Attachment #1: Type: text/plain, Size: 1539 bytes --] Hi Geert, On Mon, Nov 05, 2018 at 01:07:58PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > Thanks for your patch! > > On Mon, Nov 5, 2018 at 12:49 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > > The VIN driver bindings dictates fixed numbering for VIN endpoints connected > > to CSI-2 endpoints, even when a single endpoint exists. > > > > Without proper endpoint numbering the VIN driver fails to probe. > > > > Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2 device nodes") > > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > > Was this patch authored by you or by Matsuoka-san? The original patch didn't apply $git am index.html\?id\=1b1b73f7558d867d72e198901b84bec1e6ef1405 Applying: arm64: dts: r8a77990: Fix csi2 endpoint number in VIN node error: patch failed: arch/arm64/boot/dts/renesas/r8a77990.dtsi:811 error: arch/arm64/boot/dts/renesas/r8a77990.dtsi: patch does not apply So I made a new one, changing the commit message and adding the Fixes tag. I can change author if you want to. > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering 2018-11-05 12:46 ` jacopo mondi @ 2018-11-05 12:57 ` Geert Uytterhoeven 2018-11-05 13:08 ` jacopo mondi 0 siblings, 1 reply; 6+ messages in thread From: Geert Uytterhoeven @ 2018-11-05 12:57 UTC (permalink / raw) To: Jacopo Mondi Cc: Jacopo Mondi, Simon Horman, Laurent Pinchart, Linux-Renesas, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Koji Matsuoka, Takeshi Kihara Hi Jacopo, On Mon, Nov 5, 2018 at 1:46 PM jacopo mondi <jacopo@jmondi.org> wrote: > On Mon, Nov 05, 2018 at 01:07:58PM +0100, Geert Uytterhoeven wrote: > > On Mon, Nov 5, 2018 at 12:49 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > > > The VIN driver bindings dictates fixed numbering for VIN endpoints connected > > > to CSI-2 endpoints, even when a single endpoint exists. > > > > > > Without proper endpoint numbering the VIN driver fails to probe. > > > > > > Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2 device nodes") > > > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > > > > Was this patch authored by you or by Matsuoka-san? > > The original patch didn't apply > > $git am index.html\?id\=1b1b73f7558d867d72e198901b84bec1e6ef1405 > Applying: arm64: dts: r8a77990: Fix csi2 endpoint number in VIN node > error: patch failed: arch/arm64/boot/dts/renesas/r8a77990.dtsi:811 > error: arch/arm64/boot/dts/renesas/r8a77990.dtsi: patch does not apply Right, the BSP had the unit address and reg property, while upstream hadn't. So don't you need to re-add: #address-cells = <1>; #size-cells = <0>; else dtc complains: arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning (reg_format): /soc/video@e6ef4000/ports/port@1/endpoint@2:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format' arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning (avoid_default_addr_size): /soc/video@e6ef4000/ports/port@1/endpoint@2: Relying on default #address-cells value arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning (avoid_default_addr_size): /soc/video@e6ef4000/ports/port@1/endpoint@2: Relying on default #size-cells value arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning (graph_endpoint): /soc/video@e6ef4000/ports/port@1/endpoint@2: graph node '#address-cells' is -1, must be 1 arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning (graph_endpoint): /soc/video@e6ef4000/ports/port@1/endpoint@2: graph node '#size-cells' is -1, must be 0 > So I made a new one, changing the commit message and adding the Fixes > tag. > > I can change author if you want to. In such a case, I usually add "based on a patch in the BSP by ...", instead of the original SoB-chain. > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering 2018-11-05 12:57 ` Geert Uytterhoeven @ 2018-11-05 13:08 ` jacopo mondi 0 siblings, 0 replies; 6+ messages in thread From: jacopo mondi @ 2018-11-05 13:08 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Jacopo Mondi, Simon Horman, Laurent Pinchart, Linux-Renesas, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Koji Matsuoka, Takeshi Kihara [-- Attachment #1: Type: text/plain, Size: 3614 bytes --] Hi Geert, On Mon, Nov 05, 2018 at 01:57:07PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Mon, Nov 5, 2018 at 1:46 PM jacopo mondi <jacopo@jmondi.org> wrote: > > On Mon, Nov 05, 2018 at 01:07:58PM +0100, Geert Uytterhoeven wrote: > > > On Mon, Nov 5, 2018 at 12:49 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > > > > The VIN driver bindings dictates fixed numbering for VIN endpoints connected > > > > to CSI-2 endpoints, even when a single endpoint exists. > > > > > > > > Without proper endpoint numbering the VIN driver fails to probe. > > > > > > > > Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2 device nodes") > > > > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > > > > > > Was this patch authored by you or by Matsuoka-san? > > > > The original patch didn't apply > > > > $git am index.html\?id\=1b1b73f7558d867d72e198901b84bec1e6ef1405 > > Applying: arm64: dts: r8a77990: Fix csi2 endpoint number in VIN node > > error: patch failed: arch/arm64/boot/dts/renesas/r8a77990.dtsi:811 > > error: arch/arm64/boot/dts/renesas/r8a77990.dtsi: patch does not apply > > Right, the BSP had the unit address and reg property, while upstream hadn't. > > So don't you need to re-add: > > #address-cells = <1>; > #size-cells = <0>; > > else dtc complains: > > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning > (reg_format): /soc/video@e6ef4000/ports/port@1/endpoint@2:reg: > property has invalid length (4 bytes) (#address-cells == 2, > #size-cells == 1) > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning > (pci_device_bus_num): Failed prerequisite 'reg_format' > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning > (simple_bus_reg): Failed prerequisite 'reg_format' > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning > (i2c_bus_reg): Failed prerequisite 'reg_format' > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning > (spi_bus_reg): Failed prerequisite 'reg_format' > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning > (avoid_default_addr_size): > /soc/video@e6ef4000/ports/port@1/endpoint@2: Relying on default > #address-cells value > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning > (avoid_default_addr_size): > /soc/video@e6ef4000/ports/port@1/endpoint@2: Relying on default > #size-cells value > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning > (graph_endpoint): /soc/video@e6ef4000/ports/port@1/endpoint@2: graph > node '#address-cells' is -1, must be 1 > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dtb: Warning > (graph_endpoint): /soc/video@e6ef4000/ports/port@1/endpoint@2: graph > node '#size-cells' is -1, must be 0 Oh, sorry I didn't notice. I assumed the partent's ones were used. I have now fixed that and will send v2. Thanks j > > > So I made a new one, changing the commit message and adding the Fixes > > tag. > > > > I can change author if you want to. > > In such a case, I usually add "based on a patch in the BSP by ...", instead of > the original SoB-chain. > > > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-05 22:28 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-11-05 11:49 [PATCH] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering Jacopo Mondi 2018-11-05 12:03 ` Laurent Pinchart 2018-11-05 12:07 ` Geert Uytterhoeven 2018-11-05 12:46 ` jacopo mondi 2018-11-05 12:57 ` Geert Uytterhoeven 2018-11-05 13:08 ` jacopo mondi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).