From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
aaro.koskinen-X3B1VOXEql0@public.gmane.org,
jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org,
linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
hch-jcswGhMUV9g@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] of/device: Really only set bus DMA mask when appropriate
Date: Wed, 7 Nov 2018 09:03:35 +0100 [thread overview]
Message-ID: <20181107080335.GA24511@lst.de> (raw)
In-Reply-To: <b06321ac25a1211e572e650a630e5e1aa9f8173f.1541504601.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
On Tue, Nov 06, 2018 at 11:54:15AM +0000, Robin Murphy wrote:
> of_dma_configure() was *supposed* to be following the same logic as
> acpi_dma_configure() and only setting bus_dma_mask if some range was
> specified by the firmware. However, it seems that subtlety got lost in
> the process of fitting it into the differently-shaped control flow, and
> as a result the force_dma==true case ends up always setting the bus mask
> to the 32-bit default, which is not what anyone wants.
>
> Make sure we only touch it if the DT actually said so.
This looks good, but I think it could really use a comment as the use
of ret all the way down the function isn't exactly obvious.
Let me now if you want this picked up through the OF or DMA trees.
next prev parent reply other threads:[~2018-11-07 8:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 11:54 [PATCH] of/device: Really only set bus DMA mask when appropriate Robin Murphy
2018-11-06 19:16 ` Aaro Koskinen
2018-11-06 23:16 ` John Stultz
[not found] ` <b06321ac25a1211e572e650a630e5e1aa9f8173f.1541504601.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2018-11-07 8:03 ` Christoph Hellwig [this message]
[not found] ` <20181107080335.GA24511-jcswGhMUV9g@public.gmane.org>
2018-11-07 12:56 ` Robin Murphy
[not found] ` <22cbe798-612f-8c88-90e7-388202f603cf-5wv7dgnIgG8@public.gmane.org>
2018-11-07 15:52 ` Rob Herring
2018-11-07 16:19 ` Robin Murphy
2018-11-07 8:38 ` Geert Uytterhoeven
2018-11-07 10:32 ` Richter, Robert
[not found] ` <20181107103150.GA14853-vWBEXY7mpu582hYKe6nXyg@public.gmane.org>
2018-11-07 12:08 ` Richter, Robert
[not found] ` <20181107120821.GK3795-vWBEXY7mpu582hYKe6nXyg@public.gmane.org>
2018-11-07 12:36 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107080335.GA24511@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=aaro.koskinen-X3B1VOXEql0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org \
--cc=john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).