devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: lee.jones@linaro.org, mturquette@baylibre.com, sboyd@kernel.org,
	broonie@kernel.org, linus.walleij@linaro.org, robh+dt@kernel.org
Cc: mark.rutland@arm.com, lgirdwood@gmail.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com, linux-clk@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: [PATCH 2/6] regulator: lochnagar: Move driver to binding from DT
Date: Thu, 8 Nov 2018 10:14:01 +0000	[thread overview]
Message-ID: <20181108101405.14062-3-ckeepax@opensource.cirrus.com> (raw)
In-Reply-To: <20181108101405.14062-1-ckeepax@opensource.cirrus.com>

Based on review comments on the MFD driver, move the child drivers for
the Lochnagar MFD over to binding through device tree.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---

Mark, I would maybe hold on merging this one until discussions
on this version of the patch chain are done, just incase we
decide to go back to the single DT entry.

Thanks,
Charles

 drivers/regulator/lochnagar-regulator.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/lochnagar-regulator.c b/drivers/regulator/lochnagar-regulator.c
index 182198246479f..d08fe830b39c1 100644
--- a/drivers/regulator/lochnagar-regulator.c
+++ b/drivers/regulator/lochnagar-regulator.c
@@ -222,7 +222,7 @@ static int lochnagar_regulator_probe(struct platform_device *pdev)
 	struct regulator_dev *rdev;
 	int ret, i;
 
-	config.dev = lochnagar->dev;
+	config.dev = dev;
 	config.regmap = lochnagar->regmap;
 	config.driver_data = lochnagar;
 
@@ -241,9 +241,15 @@ static int lochnagar_regulator_probe(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id lochnagar_of_match[] = {
+	{ .compatible = "cirrus,lochnagar-regulator" },
+	{},
+};
+
 static struct platform_driver lochnagar_regulator_driver = {
 	.driver = {
 		.name = "lochnagar-regulator",
+		.of_match_table = of_match_ptr(lochnagar_of_match),
 	},
 
 	.probe = lochnagar_regulator_probe,
-- 
2.11.0

  parent reply	other threads:[~2018-11-08 10:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 10:13 [PATCH v4 0/6] Lochnagar Driver Charles Keepax
2018-11-08 10:14 ` [PATCH 1/6] regulator: lochnagar: Explicitly include register headers Charles Keepax
2018-11-08 10:14 ` Charles Keepax [this message]
2018-11-08 12:16   ` [PATCH 2/6] regulator: lochnagar: Move driver to binding from DT Mark Brown
2018-11-08 21:59     ` Charles Keepax
2018-11-08 10:14 ` [PATCH v4 3/6] mfd: lochnagar: Add initial binding documentation Charles Keepax
2018-11-13  8:28   ` Lee Jones
2018-11-13 11:16     ` Charles Keepax
2018-11-08 10:14 ` [PATCH v4 4/6] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar Charles Keepax
2018-11-13  8:31   ` Lee Jones
2018-11-08 10:14 ` [PATCH v4 5/6] clk: " Charles Keepax
2018-11-08 10:14 ` [PATCH v4 6/6] pinctrl: " Charles Keepax
2018-11-15 10:54   ` Linus Walleij
2018-11-15 11:53     ` Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181108101405.14062-3-ckeepax@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=patches@opensource.cirrus.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).