From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Vignesh R <vigneshr@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Tero Kristo <t-kristo@ti.com>, Rob Herring <robh+dt@kernel.org>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-am65: Add pinctrl regions
Date: Thu, 8 Nov 2018 07:13:56 -0800 [thread overview]
Message-ID: <20181108151356.GG56134@atomide.com> (raw)
In-Reply-To: <20181108134723.utbk7322xlqzjcfq@kahuna>
* Nishanth Menon <nm@ti.com> [181108 13:48]:
> On 16:56-20181108, Vignesh R wrote:
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65.dtsi b/arch/arm64/boot/dts/ti/k3-am65.dtsi
> > index 3d4bf369d030..873dca1d0813 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65.dtsi
> > @@ -8,6 +8,7 @@
> > #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +#include <dt-bindings/pinctrl/k3-am65.h>
> >
> > / {
> > model = "Texas Instruments K3 AM654 SoC";
> > --
> > 2.19.1
> >
>
> Where is this used? Could we mux the uart console that we are using?
> will be good to see an example of usage.
Yes please.
And please add the SoC specific macro for the pins in a format
that makes the pinconf and pinmux options separate parameters
for the macro where the usage becomes something like:
AM65X_IOPAD(0x1234, PIN_INPUT_PULLUP, 0)
The above 0 is just the mux mode number in the example.
So no more need to use MUX_MODE0 define to redefine a number
when set up that way :)
This will allow us to eventually take advantage of the
#pinctrl-cells = <2> and not have to change all the dts files
and just change the macro.
I also added Linus Walleij to Cc as this might interest him
also.
Regards,
Tony
prev parent reply other threads:[~2018-11-08 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 11:26 [PATCH 0/2] AM654: Add pinmux support Vignesh R
2018-11-08 11:26 ` [PATCH 1/2] dt-bindings: pinctrl: k3-am6: Introduce pinmux definitions Vignesh R
2018-11-08 13:45 ` Nishanth Menon
2018-11-09 8:50 ` Vignesh R
2018-11-09 9:00 ` Nishanth Menon
2018-11-08 11:26 ` [PATCH 2/2] arm64: dts: ti: k3-am65: Add pinctrl regions Vignesh R
2018-11-08 13:47 ` Nishanth Menon
2018-11-08 15:13 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108151356.GG56134@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).