From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Masney Subject: Re: [PATCH v2 5/7] pinctrl: qcom: spmi-gpio: fix gpio-hog related boot issues Date: Fri, 9 Nov 2018 05:22:13 -0500 Message-ID: <20181109102213.dijt35etkzwdvu2a@ad8ea8ed68ae> References: <20181101001149.13453-1-masneyb@onstation.org> <20181101001149.13453-6-masneyb@onstation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Bjorn Andersson , Sebastian Reichel , Rob Herring , Mark Rutland , Andy Gross , David Brown , Linux PM list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , linux-arm-msm@vger.kernel.org, "open list:ARM/QUALCOMM SUPPORT" , "open list:GPIO SUBSYSTEM" , jonathan@marek.ca List-Id: devicetree@vger.kernel.org On Fri, Nov 09, 2018 at 09:59:08AM +0100, Linus Walleij wrote: > On Thu, Nov 1, 2018 at 1:12 AM Brian Masney wrote: > > > When attempting to setup up a gpio hog, device probing would repeatedly > > fail with -EPROBE_DEFERED errors. It was caused by a circular dependency > > between the gpio and pinctrl frameworks. If the gpio-ranges property is > > present in device tree, then the gpio framework will handle the gpio pin > > registration and eliminate the circular dependency. > > > > See Christian Lamparter's commit a86caa9ba5d7 ("pinctrl: msm: fix > > gpio-hog related boot issues") for a detailed commit message that > > explains the issue in much more detail. The code comment in this commit > > came from Christian's commit. > > > > Signed-off-by: Brian Masney > > No word from Bjorn but I trust my own intuition and applied it. > > Björn: shout if it's wrong. > > Question: should this also be done for pinctrl-ssbi-gpio.c? Yes, I believe so. Brian