From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] rtc: sd3078: fix ptr_ret.cocci warnings Date: Sat, 10 Nov 2018 23:57:20 +0800 Message-ID: <20181110155720.GA122918@ivb43> References: <1541839433-28811-2-git-send-email-long17.cool@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1541839433-28811-2-git-send-email-long17.cool@163.com> Sender: linux-kernel-owner@vger.kernel.org Cc: kbuild-all@01.org, a.zummo@towertech.it, alexandre.belloni@bootlin.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, zoro List-Id: devicetree@vger.kernel.org From: kbuild test robot drivers/rtc/rtc-sd3078.c:248:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: e231edadd7fa ("rtc: sd3078: new driver.") CC: zoro Signed-off-by: kbuild test robot --- url: https://github.com/0day-ci/linux/commits/zoro/dt-bindings-define-vendor-prefix-for-whwave-Inc/20181110-205048 base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next rtc-sd3078.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/rtc/rtc-sd3078.c +++ b/drivers/rtc/rtc-sd3078.c @@ -245,10 +245,7 @@ static int sd3078_probe(struct i2c_clien sd3078_driver.driver.name, &sd3078_rtc_ops, THIS_MODULE); - if (IS_ERR(sd3078->rtc)) - return PTR_ERR(sd3078->rtc); - - return 0; + return PTR_ERR_OR_ZERO(sd3078->rtc); } static int sd3078_remove(struct i2c_client *client)