From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:36360 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728802AbeKLCDm (ORCPT ); Sun, 11 Nov 2018 21:03:42 -0500 Date: Sun, 11 Nov 2018 16:14:42 +0000 From: Jonathan Cameron Subject: Re: [PATCH v2 3/9] iio: imu: st_lsm6dsx: remove static from st_lsm6dsx_set_watermark Message-ID: <20181111161442.1836c6f5@archlinux> In-Reply-To: <19b4dfa76bb6e06ccd7aa219d7867ccfca1e9c82.1541945612.git.lorenzo.bianconi@redhat.com> References: <19b4dfa76bb6e06ccd7aa219d7867ccfca1e9c82.1541945612.git.lorenzo.bianconi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Lorenzo Bianconi Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org List-ID: On Sun, 11 Nov 2018 15:15:30 +0100 Lorenzo Bianconi wrote: > Remove static qualifier from st_lsm6dsx_set_watermark routine in > order to be reused supporting st_lsm6dsx i2c controller > > Signed-off-by: Lorenzo Bianconi Applied. This one might have been taking the one thing one patch rule a little far ;) Does no real harm though. Thanks, Jonathan > --- > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 1 + > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h > index ec204d3b4b1f..ac4cbbb0b3fb 100644 > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h > @@ -185,6 +185,7 @@ int st_lsm6dsx_probe(struct device *dev, int irq, int hw_id, const char *name, > int st_lsm6dsx_sensor_enable(struct st_lsm6dsx_sensor *sensor); > int st_lsm6dsx_sensor_disable(struct st_lsm6dsx_sensor *sensor); > int st_lsm6dsx_fifo_setup(struct st_lsm6dsx_hw *hw); > +int st_lsm6dsx_set_watermark(struct iio_dev *iio_dev, unsigned int val); > int st_lsm6dsx_update_watermark(struct st_lsm6dsx_sensor *sensor, > u16 watermark); > int st_lsm6dsx_flush_fifo(struct st_lsm6dsx_hw *hw); > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > index 961ce9d65d82..d703fcd8706a 100644 > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > @@ -600,7 +600,7 @@ static int st_lsm6dsx_write_raw(struct iio_dev *iio_dev, > return err; > } > > -static int st_lsm6dsx_set_watermark(struct iio_dev *iio_dev, unsigned int val) > +int st_lsm6dsx_set_watermark(struct iio_dev *iio_dev, unsigned int val) > { > struct st_lsm6dsx_sensor *sensor = iio_priv(iio_dev); > struct st_lsm6dsx_hw *hw = sensor->hw;