From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Mika Liljeberg <mliljeberg@nvidia.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Timo Alho <talho@nvidia.com>,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
linux-tegra@vger.kernel.org, Pekka Pessi <ppessi@nvidia.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 06/10] dt-bindings: serial: Add bindings for nvidia,tegra194-tcu
Date: Tue, 13 Nov 2018 11:03:55 +0100 [thread overview]
Message-ID: <20181113100355.GA15642@ulmo> (raw)
In-Reply-To: <f7d19f6e-0dcd-753c-a407-fcec4fa1474b@nvidia.com>
[-- Attachment #1.1: Type: text/plain, Size: 2155 bytes --]
On Tue, Nov 13, 2018 at 09:39:08AM +0000, Jon Hunter wrote:
>
> On 12/11/2018 15:18, Thierry Reding wrote:
> > From: Mikko Perttunen <mperttunen@nvidia.com>
> >
> > Add bindings for the Tegra Combined UART device used to talk to the
> > UART console on Tegra194 systems.
> >
> > Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Acked-by: Jon Hunter <jonathanh@nvidia.com>
> > Acked-by: Thierry Reding <treding@nvidia.com>
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > .../bindings/serial/nvidia,tegra194-tcu.txt | 35 +++++++++++++++++++
> > 1 file changed, 35 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt
> >
> > diff --git a/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt b/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt
> > new file mode 100644
> > index 000000000000..085a8591accd
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt
> > @@ -0,0 +1,35 @@
> > +NVIDIA Tegra Combined UART (TCU)
> > +
> > +The TCU is a system for sharing a hardware UART instance among multiple
> > +systems within the Tegra SoC. It is implemented through a mailbox-
> > +based protocol where each "virtual UART" has a pair of mailboxes, one
> > +for transmitting and one for receiving, that is used to communicate
> > +with the hardware implementing the TCU.
> > +
> > +Required properties:
> > +- name : Should be tcu
> > +- compatible
> > + Array of strings
> > + One of:
> > + - "nvidia,tegra194-tcu"
> > +- mbox-names:
> > + "rx" - Mailbox for receiving data from hardware UART
> > + "tx" - Mailbox for transmitting data to hardware UART
> > +- mboxes: Mailboxes corresponding to the mbox-names.
>
> Looks like there is some trailing white-space in the above line and git
> warns after applying this patch.
I'm not seeing it. I remember seeing that trailing space in an earlier
version of this patch and fixing it up. Did you perhaps end up applying
the wrong version?
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-11-13 10:03 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 15:18 [PATCH v2 00/10] serial: Add Tegra Combined UART driver Thierry Reding
2018-11-12 15:18 ` [PATCH v2 01/10] mailbox: Support blocking transfers in atomic context Thierry Reding
2018-11-17 17:27 ` Jassi Brar
2018-11-20 15:29 ` Thierry Reding
2018-11-21 14:27 ` Thierry Reding
2018-11-22 2:18 ` Jassi Brar
2018-11-22 8:47 ` Thierry Reding
2018-11-22 16:07 ` Jassi Brar
2018-11-22 17:34 ` Thierry Reding
2018-11-23 11:17 ` Thierry Reding
2018-11-23 11:56 ` Thierry Reding
2018-11-28 9:43 ` Jon Hunter
2018-11-28 10:08 ` Thierry Reding
2018-11-29 5:23 ` Jassi Brar
2018-11-29 15:23 ` Thierry Reding
2018-12-07 5:56 ` Jassi Brar
2018-12-07 6:19 ` Mikko Perttunen
2018-12-08 5:51 ` Jassi Brar
2018-12-08 8:50 ` Greg KH
2018-12-09 1:20 ` Jassi Brar
2018-12-07 11:32 ` Thierry Reding
2018-12-07 15:39 ` Greg KH
2018-12-08 6:09 ` Jassi Brar
2018-12-10 9:52 ` Thierry Reding
2018-12-10 20:30 ` Jassi Brar
2018-12-10 20:45 ` Thierry Reding
2018-12-10 21:32 ` Jassi Brar
2018-11-12 15:18 ` [PATCH v2 02/10] mailbox: Allow multiple controllers per device Thierry Reding
2018-11-12 15:18 ` [PATCH v2 03/10] dt-bindings: tegra186-hsp: Add shared mailboxes Thierry Reding
2018-11-12 15:18 ` [PATCH v2 04/10] mailbox: tegra-hsp: Add support for " Thierry Reding
2018-11-13 11:09 ` Jon Hunter
2018-11-13 13:09 ` Thierry Reding
2018-11-13 19:24 ` Jon Hunter
2018-11-12 15:18 ` [PATCH v2 05/10] mailbox: tegra-hsp: Add suspend/resume support Thierry Reding
2018-11-13 11:17 ` Jon Hunter
2018-12-10 9:58 ` Thierry Reding
2018-11-12 15:18 ` [PATCH v2 06/10] dt-bindings: serial: Add bindings for nvidia, tegra194-tcu Thierry Reding
2018-11-13 9:39 ` [PATCH v2 06/10] dt-bindings: serial: Add bindings for nvidia,tegra194-tcu Jon Hunter
2018-11-13 10:03 ` Thierry Reding [this message]
2018-11-13 10:11 ` Jon Hunter
2018-11-12 15:18 ` [PATCH v2 07/10] serial: Add Tegra Combined UART driver Thierry Reding
2018-11-12 15:18 ` [PATCH v2 08/10] arm64: tegra: Add nodes for TCU on Tegra194 Thierry Reding
2018-11-12 15:18 ` [PATCH v2 09/10] arm64: tegra: Mark TCU as primary serial port on Tegra194 P2888 Thierry Reding
2018-11-12 15:18 ` [PATCH v2 10/10] arm64: defconfig: Enable Tegra TCU Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113100355.GA15642@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jassisinghbrar@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mliljeberg@nvidia.com \
--cc=mperttunen@nvidia.com \
--cc=ppessi@nvidia.com \
--cc=talho@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).