From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH 0/5] media: Allwinner A10 CSI support Date: Tue, 13 Nov 2018 17:55:58 +0100 Message-ID: <20181113175558.3bfa3e8d@windsurf> References: <20181113135259.onutfjtoi25afnfe@flea> <20181113155227.62jjs3mpomwgr7xd@flea> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Hans Verkuil Cc: Maxime Ripard , Hans Verkuil , Hans Verkuil , Sakari Ailus , Mauro Carvalho Chehab , Laurent Pinchart , linux-media@vger.kernel.org, Andrzej Hajda , Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Mark Rutland , Rob Herring , Frank Rowand List-Id: devicetree@vger.kernel.org Hello, On Tue, 13 Nov 2018 17:00:25 +0100, Hans Verkuil wrote: > Weird, if I build directly from that tarball, then v4l2-compliance should say: > > v4l2-compliance SHA: not available, 64 bits > > So that's what I expect to see from buildroot as well. Indeed, that's strange, I see that the v4l2-compliance Makefile does: version.h: @if git -C $(srcdir) rev-parse HEAD >/dev/null 2>&1; then \ echo -n "#define SHA " >$@ ; \ git -C $(srcdir) rev-parse HEAD >>$@ ; \ else \ touch $@ ; \ fi which correctly uses $(srcdir), so it shouldn't go "up" the libv4l build folder and pick up the latest Buildroot commit SHA1. I'll have a quick look. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com