From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 1/4] arm64: dts: qcom: msm8998: correct xo clock name Date: Thu, 15 Nov 2018 10:26:39 -0800 Message-ID: <20181115182639.GI10915@tuxbook-pro> References: <1542302291-6864-1-git-send-email-jhugo@codeaurora.org> <1542302291-6864-2-git-send-email-jhugo@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1542302291-6864-2-git-send-email-jhugo@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Jeffrey Hugo Cc: andy.gross@linaro.org, david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Thu 15 Nov 09:18 PST 2018, Jeffrey Hugo wrote: > The root parent clock of most msm8998 clock is the "xo" clock. The DT node > is incorrectly named "xo_board", which prevents Linux from correctly > parsing the clock tree, resulting in most clocks being unparented and > unable to be manipulated. The end result is that we can't turn on clocks > for peripherals like SD, so init usually fails. > > Fixes: 4807c71cc688 (arm64: dts: Add msm8998 SoC and MTP board support) > Signed-off-by: Jeffrey Hugo > --- Reviewed-by: Bjorn Andersson > arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi > index 78227cc..a948d4b 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi > @@ -53,7 +53,7 @@ > }; > > clocks { > - xo_board { > + xo { You could have taken the opportunity and added the label here... > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <19200000>; Regards, Bjorn