From: Guenter Roeck <linux@roeck-us.net>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: ina3221: Convert to using %pOFn instead of device_node.name
Date: Sun, 18 Nov 2018 14:43:20 -0800 [thread overview]
Message-ID: <20181118224320.GA949@roeck-us.net> (raw)
In-Reply-To: <20181116220540.17222-2-robh@kernel.org>
On Fri, Nov 16, 2018 at 04:05:38PM -0600, Rob Herring wrote:
> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.
>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-hwmon@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/ina3221.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
> index d61688f04594..27abbc5b9d46 100644
> --- a/drivers/hwmon/ina3221.c
> +++ b/drivers/hwmon/ina3221.c
> @@ -469,10 +469,10 @@ static int ina3221_probe_child_from_dt(struct device *dev,
>
> ret = of_property_read_u32(child, "reg", &val);
> if (ret) {
> - dev_err(dev, "missing reg property of %s\n", child->name);
> + dev_err(dev, "missing reg property of %pOFn\n", child);
> return ret;
> } else if (val > INA3221_CHANNEL3) {
> - dev_err(dev, "invalid reg %d of %s\n", val, child->name);
> + dev_err(dev, "invalid reg %d of %pOFn\n", val, child);
> return ret;
> }
>
> @@ -490,8 +490,8 @@ static int ina3221_probe_child_from_dt(struct device *dev,
> /* Overwrite default shunt resistor value optionally */
> if (!of_property_read_u32(child, "shunt-resistor-micro-ohms", &val)) {
> if (val < 1 || val > INT_MAX) {
> - dev_err(dev, "invalid shunt resistor value %u of %s\n",
> - val, child->name);
> + dev_err(dev, "invalid shunt resistor value %u of %pOFn\n",
> + val, child);
> return -EINVAL;
> }
> input->shunt_resistor = val;
next prev parent reply other threads:[~2018-11-18 22:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 22:05 [PATCH] atm: Convert to using %pOFn instead of device_node.name Rob Herring
2018-11-16 22:05 ` [PATCH] hwmon: ina3221: " Rob Herring
2018-11-18 22:43 ` Guenter Roeck [this message]
2018-11-16 22:05 ` [PATCH] macintosh: windfarm: Another convert " Rob Herring
2018-12-07 13:07 ` Michael Ellerman
2018-11-16 22:05 ` [PATCH] pinctrl: mediatek: Convert " Rob Herring
2018-11-16 23:46 ` Sean Wang
2018-11-19 19:07 ` Rob Herring
2018-11-19 19:26 ` Sean Wang
2018-11-19 14:14 ` Linus Walleij
2018-11-18 5:52 ` [PATCH] atm: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181118224320.GA949@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).