From: Wolfram Sang <wsa@the-dreams.de>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: devicetree@vger.kernel.org,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Eugeniu Rosca <erosca@de.adit-jv.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Simon Horman <horms+renesas@verge.net.au>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: can: rcar_canfd: document r8a77965 support
Date: Mon, 19 Nov 2018 00:18:07 +0100 [thread overview]
Message-ID: <20181118231807.GE2553@kunai> (raw)
In-Reply-To: <20181118173201.4645-1-marek.vasut+renesas@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]
> + - "renesas,r8a77965-canfd" for R8A77965 (R-Car M3-N) compatible controller.
Eeeks, the 'canfd' is a suffix here not a prefix :( Not your issue,
of course. But Simon, shall we fix that for all CANFD?
> -Required properties for "renesas,r8a7795-canfd" and "renesas,r8a7796-canfd"
> -compatible:
> -In R8A7795 and R8A7796 SoCs, canfd clock is a div6 clock and can be used by both
> -CAN and CAN FD controller at the same time. It needs to be scaled to maximum
> -frequency if any of these controllers use it. This is done using the below
> -properties:
> +Required properties for "renesas,r8a7795-canfd", "renesas,r8a7796-canfd" and
> +"renesas,r8a77965-canfd" compatible:
> +In R8A7795, R8A7796 and R8A77965 SoCs, canfd clock is a div6 clock and can
> +be used by both CAN and CAN FD controller at the same time. It needs to be
> +scaled to maximum frequency if any of these controllers use it. This is done
> +using the below properties:
I think updating this paragraph does not scale. Maybe we should reformat
it the way as for plain CAN, so only in the header the new SoC gets
added? We can fix this incrementally, though, doesn't need to be
addressed within this patch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-11-18 23:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-18 17:32 [PATCH 1/2] dt-bindings: can: rcar_canfd: document r8a77965 support Marek Vasut
2018-11-18 17:32 ` [PATCH 2/2] dt-bindings: can: rcar_canfd: document r8a77990 support Marek Vasut
2018-11-21 10:20 ` Simon Horman
2019-02-16 14:00 ` Marek Vasut
2018-11-18 23:18 ` Wolfram Sang [this message]
2018-11-18 23:21 ` [PATCH 1/2] dt-bindings: can: rcar_canfd: document r8a77965 support Marek Vasut
2018-11-19 8:43 ` Geert Uytterhoeven
2018-11-19 9:40 ` Geert Uytterhoeven
2018-11-19 10:41 ` Simon Horman
2018-11-19 10:53 ` Wolfram Sang
2018-11-21 10:20 ` Simon Horman
2018-12-04 22:56 ` Rob Herring
2018-12-04 23:44 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181118231807.GE2553@kunai \
--to=wsa@the-dreams.de \
--cc=devicetree@vger.kernel.org \
--cc=erosca@de.adit-jv.com \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).