From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2 05/12] drm/sun4i: tcon: Export get tcon0 routine Date: Mon, 19 Nov 2018 09:34:36 +0100 Message-ID: <20181119083436.pbwl4djcvvmsefrw@flea> References: <20181116163916.29621-1-jagan@amarulasolutions.com> <20181116163916.29621-6-jagan@amarulasolutions.com> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="o7rjsmzestiel6jy" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20181116163916.29621-6-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Jagan Teki Cc: Maarten Lankhorst , Sean Paul , David Airlie , Rob Herring , Chen-Yu Tsai , Icenowy Zheng , Jernej Skrabec , Vasily Khoruzhick , Thierry Reding , Mark Rutland , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Michael Trimarchi , TL Lim , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-amarula-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org List-Id: devicetree@vger.kernel.org --o7rjsmzestiel6jy Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Fri, Nov 16, 2018 at 10:09:09PM +0530, Jagan Teki wrote: > Sometimes tcon attributes like tcon divider, clock rate etc are > needed in interface drivers like DSI. So for such cases interface > driver must probe the respective tcon and get the attributes. > Instead of probing tcon explictly, better export the existing > sun5i_get_tcon0 so-that the relevant interface can reuse. That's not the name of the function you export. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --o7rjsmzestiel6jy--