[PATCH 0/6] ARM: dts: am437x-gp-evm: Add pinctrl nodes

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 0/6] ARM: dts: am437x-gp-evm: Add pinctrl nodes
@ 2018-11-07  5:04 Keerthy
  2018-11-07  5:04 ` [PATCH 1/6] ARM: dts: am437x-gp-evm: Add state for ddr3 vtt toggle pin Keerthy
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Keerthy @ 2018-11-07  5:04 UTC (permalink / raw)
  To: tony
  Cc: robh+dt, mark.rutland, linux-omap, devicetree, d-gerlach,
	t-kristo, j-keerthy

The series adds pinctrl nodes for unused, debug, vtt, beeper
pins.

Tested on am437x-gp-evm for DS0. 

Dave Gerlach (5):
  ARM: dts: am437x-gp-evm: Add state for ddr3 vtt toggle pin
  ARM: dts: am437x-gp-evm: Add pinctrl for unused_pins
  ARM: dts: am437x-gp-evm: Add pinctrl for debugss pins
  ARM: dts: am437x-gp-evm: Add pinmux for gpio0 wake
  ARM: dts: am437x-gp-evm: Add uart0 pinctrl default and sleep states

Keerthy (1):
  ARM: dts: am437x-gp-evm: Add sleep state for beeper pins

 arch/arm/boot/dts/am437x-gp-evm.dts | 127 +++++++++++++++++++++++++++++++++---
 1 file changed, 117 insertions(+), 10 deletions(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/6] ARM: dts: am437x-gp-evm: Add state for ddr3 vtt toggle pin
  2018-11-07  5:04 [PATCH 0/6] ARM: dts: am437x-gp-evm: Add pinctrl nodes Keerthy
@ 2018-11-07  5:04 ` Keerthy
  2018-11-07  5:04 ` [PATCH 2/6] ARM: dts: am437x-gp-evm: Add pinctrl for unused_pins Keerthy
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Keerthy @ 2018-11-07  5:04 UTC (permalink / raw)
  To: tony
  Cc: robh+dt, mark.rutland, linux-omap, devicetree, d-gerlach,
	t-kristo, j-keerthy

From: Dave Gerlach <d-gerlach@ti.com>

Add pinctrl data for ddr_vtt_toggle pin so that it is configured
for proper state during DeepSleep0. The pin should enter DS0 off mode
and hold the line low so VTT regulator is kept off while suspended.
It is also important for the PULLUP to be set on this pin so that
on removal of isolation, the VTT line is pulled high as a requirement
for bringing the DDR3 out of self-refresh.

This toggling is dependent on the IO isolation controlled by the
wkup_m3. Without placing the IOs into isolation the DS0 states set for
the pin will not be latched into effect during suspend.

Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index 601bf4d..d119f2a 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -162,9 +162,15 @@
 
 &am43xx_pinmux {
 	pinctrl-names = "default", "sleep";
-	pinctrl-0 = <&wlan_pins_default>;
+	pinctrl-0 = <&wlan_pins_default &ddr3_vtt_toggle_default>;
 	pinctrl-1 = <&wlan_pins_sleep>;
 
+	ddr3_vtt_toggle_default: ddr_vtt_toggle_default {
+		pinctrl-single,pins = <
+			0x25C (DS0_PULL_UP_DOWN_EN | PIN_OUTPUT_PULLUP | DS0_FORCE_OFF_MODE | MUX_MODE7) /* spi0_cs0.gpio5_7 */
+		>;
+	};
+
 	i2c0_pins: i2c0_pins {
 		pinctrl-single,pins = <
 			AM4372_IOPAD(0x988, PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE0)  /* i2c0_sda.i2c0_sda */
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/6] ARM: dts: am437x-gp-evm: Add pinctrl for unused_pins
  2018-11-07  5:04 [PATCH 0/6] ARM: dts: am437x-gp-evm: Add pinctrl nodes Keerthy
  2018-11-07  5:04 ` [PATCH 1/6] ARM: dts: am437x-gp-evm: Add state for ddr3 vtt toggle pin Keerthy
@ 2018-11-07  5:04 ` Keerthy
  2018-11-07  5:04 ` [PATCH 3/6] ARM: dts: am437x-gp-evm: Add pinctrl for debugss pins Keerthy
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Keerthy @ 2018-11-07  5:04 UTC (permalink / raw)
  To: tony
  Cc: robh+dt, mark.rutland, linux-omap, devicetree, d-gerlach,
	t-kristo, j-keerthy

From: Dave Gerlach <d-gerlach@ti.com>

There are several pins on this EVM that are not in use but they can
still draw power if misconfigured. Create a pinctrl entry for these pins
and configure each one for optimal power savings.

Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
[t-kristo@ti.com: converted to use AM4372_IOPAD macro]
Signed-off-by: Tero Kristo <t-kristo@ti.com>

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts | 50 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 49 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index d119f2a..ae6b24e 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -162,7 +162,7 @@
 
 &am43xx_pinmux {
 	pinctrl-names = "default", "sleep";
-	pinctrl-0 = <&wlan_pins_default &ddr3_vtt_toggle_default>;
+	pinctrl-0 = <&wlan_pins_default &ddr3_vtt_toggle_default &unused_pins>;
 	pinctrl-1 = <&wlan_pins_sleep>;
 
 	ddr3_vtt_toggle_default: ddr_vtt_toggle_default {
@@ -532,6 +532,54 @@
 		>;
 	};
 
+	unused_pins: unused_pins {
+		pinctrl-single,pins = <
+			AM4372_IOPAD(0x854, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0x858, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0x860, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0x864, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0x868, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0x86c, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0x950, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0x990, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0x994, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0x998, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0x99c, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0x9a0, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xa3c, PIN_INPUT | PULL_DISABLE | MUX_MODE7)
+			AM4372_IOPAD(0xa40, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xa44, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xa48, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xa4c, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xa50, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xa54, PIN_INPUT | PULL_DISABLE | MUX_MODE7)
+			AM4372_IOPAD(0xa58, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xa60, PIN_INPUT | PULL_DISABLE | MUX_MODE7)
+			AM4372_IOPAD(0xa68, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xa70, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xa78, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xa7c, PIN_INPUT | PULL_DISABLE)
+			AM4372_IOPAD(0xac8, PIN_INPUT_PULLDOWN)
+			AM4372_IOPAD(0xad4, PIN_INPUT_PULLDOWN)
+			AM4372_IOPAD(0xad8, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xadc, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xae0, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xae4, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xae8, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xaec, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xaf0, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xaf4, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xaf8, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xafc, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xb00, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xb04, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xb08, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xb0c, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xb10, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xb14, PIN_INPUT_PULLDOWN | MUX_MODE7)
+			AM4372_IOPAD(0xb18, PIN_INPUT_PULLDOWN | MUX_MODE7)
+		>;
+	};
 };
 
 &uart0 {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 3/6] ARM: dts: am437x-gp-evm: Add pinctrl for debugss pins
  2018-11-07  5:04 [PATCH 0/6] ARM: dts: am437x-gp-evm: Add pinctrl nodes Keerthy
  2018-11-07  5:04 ` [PATCH 1/6] ARM: dts: am437x-gp-evm: Add state for ddr3 vtt toggle pin Keerthy
  2018-11-07  5:04 ` [PATCH 2/6] ARM: dts: am437x-gp-evm: Add pinctrl for unused_pins Keerthy
@ 2018-11-07  5:04 ` Keerthy
  2018-11-07  5:04 ` [PATCH 4/6] ARM: dts: am437x-gp-evm: Add uart0 pinctrl default and sleep states Keerthy
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Keerthy @ 2018-11-07  5:04 UTC (permalink / raw)
  To: tony
  Cc: robh+dt, mark.rutland, linux-omap, devicetree, d-gerlach,
	t-kristo, j-keerthy

From: Dave Gerlach <d-gerlach@ti.com>

The pins used by debugss are not configued by default, place pulldowns
on the pins for maximum power savings during sleep.

Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
[t-kristo@ti.com: converted to use AM4372_IOPAD macro]
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index ae6b24e..9c5e969 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -162,7 +162,7 @@
 
 &am43xx_pinmux {
 	pinctrl-names = "default", "sleep";
-	pinctrl-0 = <&wlan_pins_default &ddr3_vtt_toggle_default &unused_pins>;
+	pinctrl-0 = <&wlan_pins_default &ddr3_vtt_toggle_default &unused_pins &debugss_pins>;
 	pinctrl-1 = <&wlan_pins_sleep>;
 
 	ddr3_vtt_toggle_default: ddr_vtt_toggle_default {
@@ -580,6 +580,18 @@
 			AM4372_IOPAD(0xb18, PIN_INPUT_PULLDOWN | MUX_MODE7)
 		>;
 	};
+
+	debugss_pins: pinmux_debugss_pins {
+		pinctrl-single,pins = <
+			AM4372_IOPAD(0xa90, PIN_INPUT_PULLDOWN)
+			AM4372_IOPAD(0xa94, PIN_INPUT_PULLDOWN)
+			AM4372_IOPAD(0xa98, PIN_INPUT_PULLDOWN)
+			AM4372_IOPAD(0xa9c, PIN_INPUT_PULLDOWN)
+			AM4372_IOPAD(0xaa0, PIN_INPUT_PULLDOWN)
+			AM4372_IOPAD(0xaa4, PIN_INPUT_PULLDOWN)
+			AM4372_IOPAD(0xaa8, PIN_INPUT_PULLDOWN)
+		>;
+	};
 };
 
 &uart0 {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 4/6] ARM: dts: am437x-gp-evm: Add uart0 pinctrl default and sleep states
  2018-11-07  5:04 [PATCH 0/6] ARM: dts: am437x-gp-evm: Add pinctrl nodes Keerthy
                   ` (2 preceding siblings ...)
  2018-11-07  5:04 ` [PATCH 3/6] ARM: dts: am437x-gp-evm: Add pinctrl for debugss pins Keerthy
@ 2018-11-07  5:04 ` Keerthy
  2018-11-07  5:04 ` [PATCH 5/6] ARM: dts: am437x-gp-evm: Add pinmux for gpio0 wake Keerthy
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Keerthy @ 2018-11-07  5:04 UTC (permalink / raw)
  To: tony
  Cc: robh+dt, mark.rutland, linux-omap, devicetree, d-gerlach,
	t-kristo, j-keerthy

From: Dave Gerlach <d-gerlach@ti.com> 

Currently uart0 uses pinctrl config set by bootloader so
create default state that can be restored after a suspend
event.

Also, modify uart0 pinctrl to include RTS and CTS pins as by
default these are not in a mode for optimal power savings.

Signed-off-by: Dave Gerlach <d-gerlach@ti.com> 
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts | 30 ++++++++++++++++++++----------
 1 file changed, 20 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index 9c5e969..e52b013 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -517,15 +517,6 @@
 		>;
 	};
 
-	uart0_pins_default: uart0_pins_default {
-		pinctrl-single,pins = <
-			AM4372_IOPAD(0x968, PIN_INPUT | MUX_MODE0)		/* uart0_ctsn.uart0_ctsn */
-			AM4372_IOPAD(0x96C, PIN_OUTPUT_PULLDOWN | MUX_MODE0)	/* uart0_rtsn.uart0_rtsn */
-			AM4372_IOPAD(0x970, PIN_INPUT_PULLUP | MUX_MODE0)	/* uart0_rxd.uart0_rxd */
-			AM4372_IOPAD(0x974, PIN_OUTPUT_PULLDOWN | MUX_MODE0)	/* uart0_txd.uart0_txd */
-		>;
-	};
-
 	beeper_pins: beeper_pins {
 		pinctrl-single,pins = <
 			AM4372_IOPAD(0x9e0, PIN_OUTPUT_PULLUP | MUX_MODE7)	/* cam1_field.gpio4_12 */
@@ -592,12 +583,31 @@
 			AM4372_IOPAD(0xaa8, PIN_INPUT_PULLDOWN)
 		>;
 	};
+
+	uart0_pins_default: uart0_pins_default {
+		pinctrl-single,pins = <
+			AM4372_IOPAD(0x968, DS0_PULL_UP_DOWN_EN | INPUT_EN | MUX_MODE0) /* uart0_ctsn.uart0_ctsn */
+			AM4372_IOPAD(0x96C, DS0_PULL_UP_DOWN_EN | INPUT_EN | MUX_MODE0) /* uart0_rtsn.uart0_rtsn */
+			AM4372_IOPAD(0x970, PIN_INPUT_PULLUP | SLEWCTRL_FAST | DS0_PULL_UP_DOWN_EN | MUX_MODE0) /* uart0_rxd.uart0_rxd */
+			AM4372_IOPAD(0x974, PIN_INPUT | PULL_DISABLE | SLEWCTRL_FAST | DS0_PULL_UP_DOWN_EN | MUX_MODE0) /* uart0_txd.uart0_txd */
+		>;
+	};
+
+	uart0_pins_sleep: uart0_pins_sleep {
+		pinctrl-single,pins = <
+			AM4372_IOPAD(0x968, DS0_PULL_UP_DOWN_EN | INPUT_EN | MUX_MODE7) /* uart0_ctsn.uart0_ctsn */
+			AM4372_IOPAD(0x96C, DS0_PULL_UP_DOWN_EN | INPUT_EN | MUX_MODE7) /* uart0_rtsn.uart0_rtsn */
+			AM4372_IOPAD(0x970, PIN_INPUT_PULLUP | SLEWCTRL_FAST | DS0_PULL_UP_DOWN_EN | MUX_MODE0) /* uart0_rxd.uart0_rxd */
+			AM4372_IOPAD(0x974, PIN_INPUT_PULLDOWN | SLEWCTRL_FAST | DS0_PULL_UP_DOWN_EN | MUX_MODE0) /* uart0_txd.uart0_txd */
+		>;
+	};
 };
 
 &uart0 {
 	status = "okay";
-	pinctrl-names = "default";
+	pinctrl-names = "default", "sleep";
 	pinctrl-0 = <&uart0_pins_default>;
+	pinctrl-1 = <&uart0_pins_sleep>;
 };
 
 &i2c0 {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 5/6] ARM: dts: am437x-gp-evm: Add pinmux for gpio0 wake
  2018-11-07  5:04 [PATCH 0/6] ARM: dts: am437x-gp-evm: Add pinctrl nodes Keerthy
                   ` (3 preceding siblings ...)
  2018-11-07  5:04 ` [PATCH 4/6] ARM: dts: am437x-gp-evm: Add uart0 pinctrl default and sleep states Keerthy
@ 2018-11-07  5:04 ` Keerthy
  2018-11-07  5:04 ` [PATCH 6/6] ARM: dts: am437x-gp-evm: Add sleep state for beeper pins Keerthy
  2018-11-19 18:33 ` [PATCH 0/6] ARM: dts: am437x-gp-evm: Add pinctrl nodes Tony Lindgren
  6 siblings, 0 replies; 8+ messages in thread
From: Keerthy @ 2018-11-07  5:04 UTC (permalink / raw)
  To: tony
  Cc: robh+dt, mark.rutland, linux-omap, devicetree, d-gerlach,
	t-kristo, j-keerthy

From: Dave Gerlach <d-gerlach@ti.com>

Add pinctrl settings so that gpio0 wake from suspend will be supported
using buttons SW4 and SW7. Also, add pinctrl configuration for 0x954,
spi0_d0, which is an unused pin brought out to a header on the board
that in it's default state also connects to the gpio used for wakeup,
gpio0_3, which affects the state of the pin and prevents a working
wakeup unless we set the mux to a different state.

Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index e52b013..0127d11 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -67,7 +67,13 @@
 		debounce-delay-ms = <5>;
 		col-scan-delay-us = <2>;
 
-		row-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH /* Bank3, pin21 */
+		pinctrl-names = "default", "sleep";
+		pinctrl-0 = <&matrix_keypad_default>;
+		pinctrl-1 = <&matrix_keypad_sleep>;
+
+		linux,wakeup;
+
+		row-gpios = <&gpio0 3 GPIO_ACTIVE_HIGH /* Bank0, pin3 */
 				&gpio4 3 GPIO_ACTIVE_HIGH /* Bank4, pin3 */
 				&gpio4 2 GPIO_ACTIVE_HIGH>; /* Bank4, pin2 */
 
@@ -601,6 +607,24 @@
 			AM4372_IOPAD(0x974, PIN_INPUT_PULLDOWN | SLEWCTRL_FAST | DS0_PULL_UP_DOWN_EN | MUX_MODE0) /* uart0_txd.uart0_txd */
 		>;
 	};
+
+	matrix_keypad_default: matrix_keypad_default {
+		pinctrl-single,pins = <
+			AM4372_IOPAD(0x9a4, PIN_OUTPUT | MUX_MODE7)
+			AM4372_IOPAD(0x9a8, PIN_OUTPUT | MUX_MODE7)
+			AM4372_IOPAD(0x9ac, PIN_INPUT | PULL_DISABLE | MUX_MODE9)
+			AM4372_IOPAD(0x954, PIN_INPUT_PULLDOWN | MUX_MODE0)
+		>;
+	};
+
+	matrix_keypad_sleep: matrix_keypad_sleep {
+		pinctrl-single,pins = <
+			AM4372_IOPAD(0x9a4, PULL_UP | MUX_MODE7)
+			AM4372_IOPAD(0x9a8, PULL_UP | MUX_MODE7)
+			AM4372_IOPAD(0x9ac, PIN_INPUT | PULL_DISABLE | MUX_MODE9)
+			AM4372_IOPAD(0x954, PIN_INPUT_PULLDOWN | MUX_MODE0)
+		>;
+	};
 };
 
 &uart0 {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 6/6] ARM: dts: am437x-gp-evm: Add sleep state for beeper pins
  2018-11-07  5:04 [PATCH 0/6] ARM: dts: am437x-gp-evm: Add pinctrl nodes Keerthy
                   ` (4 preceding siblings ...)
  2018-11-07  5:04 ` [PATCH 5/6] ARM: dts: am437x-gp-evm: Add pinmux for gpio0 wake Keerthy
@ 2018-11-07  5:04 ` Keerthy
  2018-11-19 18:33 ` [PATCH 0/6] ARM: dts: am437x-gp-evm: Add pinctrl nodes Tony Lindgren
  6 siblings, 0 replies; 8+ messages in thread
From: Keerthy @ 2018-11-07  5:04 UTC (permalink / raw)
  To: tony
  Cc: robh+dt, mark.rutland, linux-omap, devicetree, d-gerlach,
	t-kristo, j-keerthy

Add sleep state for beeper pins. Without this there was a power
increase during the suspend and standby states on V3_3D domain.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index 0127d11..f4a20ca 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -161,7 +161,8 @@
 	beeper: beeper {
 		compatible = "gpio-beeper";
 		pinctrl-names = "default";
-		pinctrl-0 = <&beeper_pins>;
+		pinctrl-0 = <&beeper_pins_default>;
+		pinctrl-1 = <&beeper_pins_sleep>;
 		gpios = <&gpio4 12 GPIO_ACTIVE_HIGH>;
 	};
 };
@@ -523,12 +524,18 @@
 		>;
 	};
 
-	beeper_pins: beeper_pins {
+	beeper_pins_default: beeper_pins_default {
 		pinctrl-single,pins = <
 			AM4372_IOPAD(0x9e0, PIN_OUTPUT_PULLUP | MUX_MODE7)	/* cam1_field.gpio4_12 */
 		>;
 	};
 
+	beeper_pins_sleep: beeper_pins_sleep {
+		pinctrl-single,pins = <
+			AM4372_IOPAD(0x9e0, PIN_INPUT_PULLDOWN | MUX_MODE7)	/* cam1_field.gpio4_12 */
+		>;
+	};
+
 	unused_pins: unused_pins {
 		pinctrl-single,pins = <
 			AM4372_IOPAD(0x854, PIN_INPUT_PULLDOWN | MUX_MODE7)
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/6] ARM: dts: am437x-gp-evm: Add pinctrl nodes
  2018-11-07  5:04 [PATCH 0/6] ARM: dts: am437x-gp-evm: Add pinctrl nodes Keerthy
                   ` (5 preceding siblings ...)
  2018-11-07  5:04 ` [PATCH 6/6] ARM: dts: am437x-gp-evm: Add sleep state for beeper pins Keerthy
@ 2018-11-19 18:33 ` Tony Lindgren
  6 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2018-11-19 18:33 UTC (permalink / raw)
  To: Keerthy; +Cc: robh+dt, mark.rutland, linux-omap, devicetree, d-gerlach,
	t-kristo

* Keerthy <j-keerthy@ti.com> [181106 21:04]:
> The series adds pinctrl nodes for unused, debug, vtt, beeper
> pins.
> 
> Tested on am437x-gp-evm for DS0. 

Applying into omap-for-v4.21/dt thanks.

Tony

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-11-19 18:33 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-07  5:04 [PATCH 0/6] ARM: dts: am437x-gp-evm: Add pinctrl nodes Keerthy
2018-11-07  5:04 ` [PATCH 1/6] ARM: dts: am437x-gp-evm: Add state for ddr3 vtt toggle pin Keerthy
2018-11-07  5:04 ` [PATCH 2/6] ARM: dts: am437x-gp-evm: Add pinctrl for unused_pins Keerthy
2018-11-07  5:04 ` [PATCH 3/6] ARM: dts: am437x-gp-evm: Add pinctrl for debugss pins Keerthy
2018-11-07  5:04 ` [PATCH 4/6] ARM: dts: am437x-gp-evm: Add uart0 pinctrl default and sleep states Keerthy
2018-11-07  5:04 ` [PATCH 5/6] ARM: dts: am437x-gp-evm: Add pinmux for gpio0 wake Keerthy
2018-11-07  5:04 ` [PATCH 6/6] ARM: dts: am437x-gp-evm: Add sleep state for beeper pins Keerthy
2018-11-19 18:33 ` [PATCH 0/6] ARM: dts: am437x-gp-evm: Add pinctrl nodes Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).