* [PATCH 1/2] dt-bindings: pinctrl: fix qcom-pmic-gpio for pms405
@ 2018-11-20 5:45 Shawn Guo
2018-11-20 5:45 ` [PATCH 2/2] pinctrl: qcom: spmi-gpio: add compatible for pms405 GPIO Shawn Guo
2018-11-26 8:12 ` [PATCH 1/2] dt-bindings: pinctrl: fix qcom-pmic-gpio for pms405 Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Shawn Guo @ 2018-11-20 5:45 UTC (permalink / raw)
To: Linus Walleij
Cc: Rob Herring, Bjorn Andersson, Vinod Koul, linux-arm-msm,
devicetree, linux-gpio, Shawn Guo
Rather than gpio1-gpio11 for pms405, there are 12 GPIOs for pms405.
But gpio1, gpio9 and gpio10 are not available. Fix the bindings doc
to make it correct for pms405.
Fixes: ed80f6eb799a ("dt-bindings: pinctrl: qcom-pmic-gpio: Add pms405 support")
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
index ab4000eab07d..759aa1732e48 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
@@ -92,7 +92,7 @@ to specify in a pin configuration subnode:
gpio1-gpio26 for pm8998
gpio1-gpio22 for pma8084
gpio1-gpio10 for pmi8994
- gpio1-gpio11 for pms405
+ gpio1-gpio12 for pms405 (holes on gpio1, gpio9 and gpio10)
- function:
Usage: required
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] pinctrl: qcom: spmi-gpio: add compatible for pms405 GPIO
2018-11-20 5:45 [PATCH 1/2] dt-bindings: pinctrl: fix qcom-pmic-gpio for pms405 Shawn Guo
@ 2018-11-20 5:45 ` Shawn Guo
2018-11-26 8:13 ` Linus Walleij
2018-11-26 8:12 ` [PATCH 1/2] dt-bindings: pinctrl: fix qcom-pmic-gpio for pms405 Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2018-11-20 5:45 UTC (permalink / raw)
To: Linus Walleij
Cc: Rob Herring, Bjorn Andersson, Vinod Koul, linux-arm-msm,
devicetree, linux-gpio, Shawn Guo
Let's add "qcom,pms405-gpio" to match table, as commit ed80f6eb799a
("dt-bindings: pinctrl: qcom-pmic-gpio: Add pms405 support") already
adds the compatible.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index a29efbe08f48..21ccf94b22ea 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1055,6 +1055,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
{ .compatible = "qcom,pm8994-gpio" }, /* 22 GPIO's */
{ .compatible = "qcom,pmi8994-gpio" }, /* 10 GPIO's */
{ .compatible = "qcom,pma8084-gpio" }, /* 22 GPIO's */
+ { .compatible = "qcom,pms405-gpio" }, /* 12 GPIO's, holes on 1 9 10 */
{ .compatible = "qcom,spmi-gpio" }, /* Generic */
{ },
};
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] pinctrl: qcom: spmi-gpio: add compatible for pms405 GPIO
2018-11-20 5:45 ` [PATCH 2/2] pinctrl: qcom: spmi-gpio: add compatible for pms405 GPIO Shawn Guo
@ 2018-11-26 8:13 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2018-11-26 8:13 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring, Bjorn Andersson, vkoul, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:GPIO SUBSYSTEM
On Tue, Nov 20, 2018 at 6:45 AM Shawn Guo <shawn.guo@linaro.org> wrote:
> Let's add "qcom,pms405-gpio" to match table, as commit ed80f6eb799a
> ("dt-bindings: pinctrl: qcom-pmic-gpio: Add pms405 support") already
> adds the compatible.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Patch applied (unless Björn has objections).
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pinctrl: fix qcom-pmic-gpio for pms405
2018-11-20 5:45 [PATCH 1/2] dt-bindings: pinctrl: fix qcom-pmic-gpio for pms405 Shawn Guo
2018-11-20 5:45 ` [PATCH 2/2] pinctrl: qcom: spmi-gpio: add compatible for pms405 GPIO Shawn Guo
@ 2018-11-26 8:12 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2018-11-26 8:12 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring, Bjorn Andersson, vkoul, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:GPIO SUBSYSTEM
On Tue, Nov 20, 2018 at 6:45 AM Shawn Guo <shawn.guo@linaro.org> wrote:
> Rather than gpio1-gpio11 for pms405, there are 12 GPIOs for pms405.
> But gpio1, gpio9 and gpio10 are not available. Fix the bindings doc
> to make it correct for pms405.
>
> Fixes: ed80f6eb799a ("dt-bindings: pinctrl: qcom-pmic-gpio: Add pms405 support")
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Patch applied (unless Björn has objections).
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-26 8:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-20 5:45 [PATCH 1/2] dt-bindings: pinctrl: fix qcom-pmic-gpio for pms405 Shawn Guo
2018-11-20 5:45 ` [PATCH 2/2] pinctrl: qcom: spmi-gpio: add compatible for pms405 GPIO Shawn Guo
2018-11-26 8:13 ` Linus Walleij
2018-11-26 8:12 ` [PATCH 1/2] dt-bindings: pinctrl: fix qcom-pmic-gpio for pms405 Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).